The functions in rpc/util.cpp would call functions in script/standard.cpp which in libbitcoin-common. This could cause problem if the linker does not strip out unused function while linking bitcoin-cli.
build: Move rpc/util.cpp from libbitcoin-util to libbitcoin-server #13486
pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:move_util_to_common changing 1 files +1 −1-
ken2812221 commented at 3:01 AM on June 17, 2018: contributor
- fanquake added the label Build system on Jun 17, 2018
-
Empact commented at 9:02 PM on June 17, 2018: member
How about moving it to
libbitcoin_serverinstead, since that seems to be the highest common use? It's included byrpc/miscandwallet/rpcwallet, which are inlibbitcoin_serverandlibbitcoin_wallet. -
Move rpc/util.cpp from libbitcoin-util to libbitcoin-server 471a4992d4
- ken2812221 force-pushed on Jun 18, 2018
-
ken2812221 commented at 3:05 AM on June 18, 2018: contributor
@Empact Sure.
- ken2812221 renamed this:
build: Move rpc/util.cpp from libbitcoin-util to libbitcoin-common
build: Move rpc/util.cpp from libbitcoin-util to libbitcoin-server
on Jun 18, 2018 -
laanwj commented at 10:35 AM on June 18, 2018: member
Concept ACK - RPC stuff that is not used in the client definitely belongs in
libbitcoin_server. -
laanwj commented at 2:13 PM on June 18, 2018: member
utACK 471a4992d4a4477d7e234a82d3639d06f4572e9a, checked that all the functions in
rpc/util.hare only used in other compilation units belonging to the RPC server. -
Empact commented at 1:06 AM on June 19, 2018: member
utACK 471a499
- laanwj merged this on Jun 24, 2018
- laanwj closed this on Jun 24, 2018
- laanwj referenced this in commit 66e1a08d6f on Jun 24, 2018
- ken2812221 deleted the branch on Jun 24, 2018
- PastaPastaPasta referenced this in commit 1ade2e84c1 on Jul 7, 2020
- PastaPastaPasta referenced this in commit 0b71de50e0 on Jul 7, 2020
- PastaPastaPasta referenced this in commit 300aea67dd on Jul 8, 2020
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels