Also removes the QT_VERSION check around the QFontDatabase #include. QFontDatabase has existed since at least Qt 4.2.
This can go in after #13458.
gui: Add leading 0 to QT_VERSION check for QFontDatabase #13493
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove-qtversion-qfontdatabase changing 1 files +2 −5-
fanquake commented at 4:34 AM on June 18, 2018: member
-
c8c79cd628
gui: Add leading 0 to QT_VERSION check for QFontDatabase
Also, remove the QT_VERSION check around the QFontDatabase #include.
- fanquake added the label GUI on Jun 18, 2018
-
laanwj commented at 10:02 AM on June 18, 2018: member
A matter of taste, I think the motivation for this
#ifdefis to avoid including unnecessary things. Agree it's not strictly necessary. -
DrahtBot commented at 10:39 PM on June 19, 2018: member
<!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
-
laanwj commented at 2:10 PM on June 24, 2018: member
Agree, however in a .cpp I think it's ok.
My worry is: we had an issue recently (#13314) where someone removed an unguarded
#includeunder the impression that it wasn't needed. It was needed on some platform. -
MarcoFalke commented at 2:15 PM on June 24, 2018: member
I think keeping the include guard until we bump the minimum required qt version above that is fine.
-
MarcoFalke commented at 2:16 PM on June 24, 2018: member
Changing the formatting of the constant (prefix 0) seems fine, though.
-
laanwj commented at 4:54 PM on June 24, 2018: member
Closing then, this is not worth changing IMO.
- laanwj closed this on Jun 24, 2018
- fanquake deleted the branch on Aug 7, 2018
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels