travis: Enable qt for all jobs

ken2812221 commented at 4:10 am on June 21, 2018: contributor

If depends build take more than 20 mins, skip Bitcoin Core build to store depends caches and mark it fail. Then restart the job for Bitcoin Core build.
Enable Qt build for Windows and 32-bit Linux
Enable wallet for depends x86-64 Linux
Disable gui tests for Windows since they are not supported

This would be helpful for upgrading Qt (#12971) and protobuf (#13513)

fanquake added the label Tests on Jun 21, 2018

in .travis.yml:33 in 1da0703eef outdated

27@@ -28,11 +28,11 @@ env:
28 # ARM
29     - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf" DEP_OPTS="NO_QT=1" GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
30 # Win32
31-    - HOST=i686-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="python3 nsis g++-mingw-w64-i686 wine-binfmt wine32" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"
32+    - HOST=i686-w64-mingw32 DPKG_ADD_ARCH="i386" PACKAGES="python3 nsis g++-mingw-w64-i686 wine-binfmt wine32" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports --disable-gui-tests"
33 # Win64
34-    - HOST=x86_64-w64-mingw32 DEP_OPTS="NO_QT=1" PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine-binfmt wine64" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"
35+    - HOST=x86_64-w64-mingw32 PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine-binfmt wine64" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports --disable-gui-tests"

MarcoFalke commented at 12:07 pm on June 21, 2018:

Might as well change “install” to “deploy”, so we get the setup.exe as well?

ken2812221 commented at 3:48 pm on June 21, 2018:

Sure

MarcoFalke commented at 12:31 pm on June 21, 2018: member

Would be nicer if travis natively supported multi-job-multi-stage builds, but yeah, maybe this hack is required.

ken2812221 force-pushed on Jun 21, 2018

laanwj requested review from theuni on Jun 24, 2018

DrahtBot commented at 11:43 am on June 30, 2018: member

#14231 (travis: Save cache even when build or test fail by ken2812221)
#13827 ([WIP] depends: Add native_nsis to support unicode by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

ken2812221 force-pushed on Jul 18, 2018

ken2812221 renamed this:
~~travis: Enable Qt build for Windows and 32-bit Linux~~
travis: Enable Qt build for Windows , i686 and arm Linux
on Jul 18, 2018

ken2812221 commented at 0:09 am on July 18, 2018: contributor

Update: Enable qt for arm

ken2812221 force-pushed on Jul 18, 2018

in .travis.yml:50 in 792842b8b0 outdated

71-    - DOCKER_EXEC ./configure --cache-file=../config.cache $BITCOIN_CONFIG_ALL $BITCOIN_CONFIG || ( cat config.log && false)
72-    - DOCKER_EXEC make $MAKEJOBS $GOAL || ( echo "Build failure. Verbose build follows." && DOCKER_EXEC make $GOAL V=1 ; false )
73-    - if [ "$RUN_TESTS" = "true" ]; then DOCKER_EXEC LD_LIBRARY_PATH=$TRAVIS_BUILD_DIR/depends/$HOST/lib make $MAKEJOBS check VERBOSE=1; fi
74-    - if [ "$TRAVIS_EVENT_TYPE" = "cron" ]; then extended="--extended --exclude feature_pruning,feature_dbcrash"; fi
75-    - if [ "$RUN_TESTS" = "true" ]; then DOCKER_EXEC test/functional/test_runner.py --combinedlogslen=4000 --coverage --quiet --failfast ${extended}; fi
76+    # Skip Bitcoin Core build if depends build take more than 20 mins.

MarcoFalke commented at 0:40 am on July 18, 2018:

hmm. Not sure about that. We’d have to manually reset travis on all pull requests that are affected by this.

ken2812221 commented at 0:54 am on July 18, 2018:

We’d have to manually reset travis on all pull requests that are affected by this.

We can clear the cache of all PRs to solve this just like what we do after migrate tests to docker.

MarcoFalke commented at 1:11 am on July 18, 2018:

What I mean is that a early exit should not make travis green. Maybe add an echo "Travis early exit to cache current state" && false somewhere?

ken2812221 commented at 1:17 am on July 18, 2018:

It does not make travis green. If test $SECONDS -lt 1200 has failed, travis would turn out red. But it’s a good idea to add error message.

MarcoFalke commented at 1:26 am on July 18, 2018:

Ah thanks for the clarification. I missed that.

ken2812221 force-pushed on Jul 18, 2018

DrahtBot added the label Needs rebase on Jul 30, 2018

ken2812221 force-pushed on Aug 1, 2018

DrahtBot removed the label Needs rebase on Aug 1, 2018

in .travis.yml:52 in 6175169626 outdated

122-    - if [ "$RUN_TESTS" = "true" ]; then BEGIN_FOLD unit-tests; DOCKER_EXEC LD_LIBRARY_PATH=$TRAVIS_BUILD_DIR/depends/$HOST/lib make $MAKEJOBS check VERBOSE=1; END_FOLD; fi
123-    - if [ "$TRAVIS_EVENT_TYPE" = "cron" ]; then extended="--extended --exclude feature_pruning,feature_dbcrash"; fi
124-    - if [ "$RUN_TESTS" = "true" ]; then BEGIN_FOLD functional-tests; DOCKER_EXEC test/functional/test_runner.py --combinedlogslen=4000 --coverage --quiet --failfast ${extended}; END_FOLD; fi
125+    # Skip Bitcoin Core build if depends build take more than 20 mins.
126+    - |
127+      ( test $SECONDS -lt 1200 || ( echo Travis early exit to cache current state && false ) ) && (

scravy commented at 2:48 pm on August 1, 2018:

This could simply be its own line in the script section.

I really like the rest of the script to be joined into a single block using the | YAML goodness, but putting this check on an individual line (- ...) would spare the ) && ( LOTSOFLINES ) awkwardness.

scravy commented at 5:47 pm on August 3, 2018:

As I learned in #13863 – if you split the script like that then the exit codes of the commands in each line will not make the script fail, i.e. if the unit tests fail the build will not fail.

ken2812221 commented at 7:49 am on August 6, 2018:

Thanks, I’ll work on this after #13836 merged.

DrahtBot added the label Needs rebase on Aug 2, 2018

ken2812221 force-pushed on Aug 3, 2018

ken2812221 renamed this:
~~travis: Enable Qt build for Windows , i686 and arm Linux~~
travis: avoid timeout without saving caches, also enable all qt
on Aug 3, 2018

ken2812221 force-pushed on Aug 3, 2018

DrahtBot removed the label Needs rebase on Aug 3, 2018

ken2812221 force-pushed on Aug 3, 2018

ken2812221 commented at 3:39 pm on August 3, 2018: contributor

It’s time to make Mac build work on master again.

in .travis.yml:126 in 39cfb0fe48 outdated

122@@ -123,12 +123,11 @@ jobs:
123         RUN_TESTS=true
124         GOAL="install"
125         BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --enable-glibc-back-compat --enable-reduce-exports --with-gui=qt5 CPPFLAGS=-DDEBUG_LOCKORDER"
126-# x86_64 Linux, No wallet
127+# x86_64 Linux

scravy commented at 5:50 pm on August 3, 2018:

Is this change intentional? I find it very handy to have a NO_WALLET build available. It has happened to me before that I changed something in a way which required the wallet in a place which does not require a wallet overall. This particular travis build caught that.

scravy commented at 5:57 pm on August 3, 2018:

Sorry, I just noticed your description does mention that. So it is intentional. My comment still stands though, I find it beneficial to have a no-wallet build available. In a perfect world a build would build all possible combinations of build flags, in this imperfect world it can at least check the no-wallet case.

ken2812221 commented at 7:51 am on August 6, 2018:

Indeed, will undo this.

scravy changes_requested

DrahtBot added the label Needs rebase on Aug 27, 2018

ken2812221 force-pushed on Aug 29, 2018

DrahtBot removed the label Needs rebase on Aug 29, 2018

ken2812221 force-pushed on Aug 30, 2018

ken2812221 closed this on Aug 30, 2018

ken2812221 deleted the branch on Aug 30, 2018

ken2812221 restored the branch on Aug 30, 2018

ken2812221 reopened this on Aug 30, 2018

ken2812221 force-pushed on Aug 30, 2018

ken2812221 force-pushed on Sep 1, 2018

ken2812221 renamed this:
~~travis: avoid timeout without saving caches, also enable all qt~~
travis: Avoid being timeout without saving caches, also enable qt builds for all jobs if available
on Sep 1, 2018

ken2812221 commented at 5:00 pm on September 1, 2018: contributor

This is ready for review. Thanks for #13863, I don’t have to do a lot of line changes.

ken2812221 force-pushed on Sep 1, 2018

MarcoFalke commented at 7:56 pm on September 4, 2018: member

As this is effectively reverting a33b7c9cb545985771d074748c0e368ca2d06702, could the GOALs be changed to deploy?

ken2812221 force-pushed on Sep 4, 2018

ken2812221 force-pushed on Sep 5, 2018

ken2812221 commented at 9:29 am on September 5, 2018: contributor

@MarcoFalke Changed goals to deploy, also revert 3d69853090a9382fc31b1558a74627f61f002584 because of cf01fd6f9c1a31d16884cd1a1a686602b4b47027

in .travis.yml:132 in 13e65f8b77 outdated

128@@ -133,5 +129,5 @@ jobs:
129         OSX_SDK=10.11
130         RUN_UNIT_TESTS=false
131         RUN_FUNCTIONAL_TESTS=false
132-        GOAL="all deploy"
133+        GOAL="deploy"

MarcoFalke commented at 1:19 pm on September 5, 2018:

Why is this change needed? It doesn’t seem like the mac cross build should be affected at all?

ken2812221 commented at 7:56 pm on September 5, 2018:

The origin motivation of 3d69853 is to compile all binaries, not only qt. But after cf01fd6 being merged, it would build all binaries even when the target is deploy. What all do has been included in what deploy do.

ken2812221 commented at 3:10 am on September 10, 2018:

@MarcoFalke Do you think that this change is unnecessary?

ken2812221 force-pushed on Sep 10, 2018

travis: avoid timeout without saving caches, also enable all qt 3387bb0829

ken2812221 force-pushed on Sep 10, 2018

ken2812221 renamed this:
~~travis: Avoid being timeout without saving caches, also enable qt builds for all jobs if available~~
travis: Avoid timeout without saving caches, also enable qt builds for all jobs if available
on Sep 30, 2018

ken2812221 renamed this:
~~travis: Avoid timeout without saving caches, also enable qt builds for all jobs if available~~
travis: Enable qt for all jobs
on Oct 11, 2018

in .travis.yml:37 in 3387bb0829

33@@ -34,7 +34,7 @@ install:
34 before_script:
35   - set -o errexit; source .travis/test_05_before_script.sh
36 script:
37-  - set -o errexit; source .travis/test_06_script.sh
38+  - if [ $SECONDS -gt 1200 ]; then set +o errexit; echo "Travis early exit to cache current state"; false; else set -o errexit; source .travis/test_06_script.sh; fi

Sjors commented at 3:49 am on October 26, 2018:

Should this be in the before_script?

MarcoFalke commented at 11:50 am on October 26, 2018:

before_script does the depends build, which should be cached, so no?

Sjors commented at 5:48 am on October 27, 2018:

I didn’t know chache was discared during a premature exit. If so, then this makes sense.

Sjors commented at 3:54 am on October 26, 2018: member

Concept ACK

MarcoFalke merged this on Oct 26, 2018

MarcoFalke closed this on Oct 26, 2018

MarcoFalke referenced this in commit f4e4ea1cee on Oct 26, 2018

ken2812221 deleted the branch on Oct 27, 2018

Munkybooty referenced this in commit bf4bb4b60b on Jul 21, 2021

Munkybooty referenced this in commit 1c412d10cb on Jul 21, 2021

Munkybooty referenced this in commit 31eb125b9f on Jul 22, 2021

Munkybooty referenced this in commit 03981cebc8 on Jul 22, 2021

Munkybooty referenced this in commit 1e2f6aa8a3 on Jul 23, 2021

DrahtBot locked this on Sep 8, 2021

travis: Enable qt for all jobs #13515