[WIP] depends: Add native_nsis to support unicode #13827

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:depends-nsis changing 6 files +54 −6
  1. ken2812221 commented at 1:35 PM on August 1, 2018: contributor

    Since version 3.0, nsis start to support unicode. However, Bionic still use 2.51. So, it might be a good reason to add nsis into dependency list to support unicode.

    Fix #13817 Close #8825

    TODO:

    • Gitian build should be deterministic
  2. fanquake added the label Build system on Aug 1, 2018
  3. fanquake commented at 1:38 PM on August 1, 2018: member

    Concept ACK This and Unicode true was what I was looking into in regards to #13817.

    Looks like the whitespace linter is unhappy.

  4. DrahtBot commented at 1:58 PM on August 1, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->Reviewers, this pull request conflicts with the following ones:

    • #13515 (travis: Enable qt for all jobs by ken2812221)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. MarcoFalke added this to the milestone 0.18.0 on Aug 1, 2018
  6. MarcoFalke commented at 2:03 PM on August 1, 2018: member

    Since this is not a regression, I have assigned the 0.18.0 milestone for now.

  7. ken2812221 force-pushed on Aug 1, 2018
  8. in depends/packages/native_zlib_posix.mk:18 in 33245565fc outdated 
      13 | +endef

  14 | +

  15 | +define $(package)_stage_cmds

  16 | +  $(MAKE) install prefix=$($(package)_staging_prefix_dir)

  17 | +endef

  18 | +
    MarcoFalke commented at 2:05 PM on August 1, 2018:

    Please use "linux encoding" for the "new line characters"

  9. ken2812221 force-pushed on Aug 1, 2018
  10. ken2812221 force-pushed on Aug 1, 2018
  11. ken2812221 force-pushed on Aug 1, 2018
  12. laanwj commented at 3:29 PM on August 1, 2018: member

    Crap, one of the reasons we upgraded to bionic in the first place is to upgrade NSIS, not really happy that we end up compiling it anyway now. But yes, let's put this for 0.18, this is not a new problem (and comes extremely last-minute for 0.17).

  13. ken2812221 force-pushed on Aug 1, 2018
  14. ken2812221 force-pushed on Aug 1, 2018
  15. ken2812221 force-pushed on Aug 1, 2018
  16. ken2812221 force-pushed on Aug 2, 2018
  17. ken2812221 force-pushed on Aug 2, 2018
  18. ken2812221 force-pushed on Aug 2, 2018
  19. ken2812221 force-pushed on Aug 2, 2018
  20. ken2812221 force-pushed on Aug 2, 2018
  21. ken2812221 renamed this:
    depends: Add native_nsis to support unicode
    wip, depends: Add native_nsis to support unicode
    on Aug 2, 2018
  22. ken2812221 force-pushed on Aug 2, 2018
  23. ken2812221 renamed this:
    wip, depends: Add native_nsis to support unicode
    depends: Add native_nsis to support unicode
    on Aug 2, 2018
  24. in depends/packages/native_nsis.mk:9 in b0753d1dc8 outdated 
       0 | @@ -0,0 +1,27 @@
   1 | +package=native_nsis
   2 | +$(package)_version=3.03
   3 | +$(package)_download_path=https://sourceforge.net/projects/nsis/files/NSIS%203/$($(package)_version)
   4 | +$(package)_file_name=nsis-$($(package)_version)-src.tar.bz2
   5 | +$(package)_sha256_hash=abae7f4488bc6de7a4dd760d5f0e7cd3aad7747d4d7cd85786697c8991695eaa
   6 | +$(package)_dependencies=native_zlib
   7 | +
   8 | +define $(package)_set_vars
   9 | +$(package)_build_opts  = -j4
    ken2812221 commented at 11:54 AM on August 2, 2018:

    I'm not sure what the best number is here.

    MarcoFalke commented at 11:56 AM on August 2, 2018:

    Can't you use the passed down number from make depends -j yy?

    ken2812221 commented at 11:59 AM on August 2, 2018:

    nsis is not built by make, so it is incompatible with make jobs.

    ken2812221 commented at 12:00 PM on August 2, 2018:

    Or there is a way to get job number?

    MarcoFalke commented at 12:08 PM on August 2, 2018:

    Not that I am aware of. Other than that you might just set the number of jobs so that they use less than 1GB of RAM, since that is our minimum requirement to get built.

    ken2812221 commented at 7:55 AM on August 6, 2018:

    After testing a few times, there are some edge case fail to cd directories in multi-job. Will remove this.

  25. ken2812221 force-pushed on Aug 6, 2018
  26. ken2812221 force-pushed on Aug 6, 2018
  27. ken2812221 renamed this:
    depends: Add native_nsis to support unicode
    wip, depends: Add native_nsis to support unicode
    on Aug 7, 2018
  28. laanwj added the label Windows on Aug 7, 2018
  29. MarcoFalke added the label Needs gitian build on Aug 7, 2018
  30. ken2812221 commented at 6:15 PM on August 7, 2018: contributor

    @MarcoFalke This is not ready for gitian build since it is not deterministic.

  31. DrahtBot removed the label Needs gitian build on Aug 8, 2018
  32. ken2812221 force-pushed on Aug 15, 2018
  33. ken2812221 force-pushed on Aug 15, 2018
  34. ken2812221 force-pushed on Aug 15, 2018
  35. ken2812221 force-pushed on Aug 15, 2018
  36. ken2812221 force-pushed on Aug 16, 2018
  37. ken2812221 force-pushed on Aug 16, 2018
  38. ken2812221 force-pushed on Aug 16, 2018
  39. ken2812221 force-pushed on Aug 17, 2018
  40. ken2812221 force-pushed on Aug 17, 2018
  41. ken2812221 commented at 10:16 AM on August 22, 2018: contributor

    I have no idea why the following things would happen? I already put scons into faketime wrapper, but the compiled stub files still contain timestamp in PE header. The alternative way is to hack the compiled PE file timestamp and set it to a constant.

  42. MarcoFalke deleted a comment on Aug 22, 2018
  43. ken2812221 force-pushed on Aug 22, 2018
  44. DrahtBot added the label Needs rebase on Aug 27, 2018
  45. ken2812221 force-pushed on Aug 29, 2018
  46. depends: native_nsis 42cc79bc1d
  47. ken2812221 force-pushed on Aug 29, 2018
  48. DrahtBot removed the label Needs rebase on Aug 29, 2018
  49. ken2812221 commented at 7:53 PM on August 30, 2018: contributor

    @theuni Do you have any idea what would break the deterministic?

  50. MarcoFalke commented at 7:55 PM on August 30, 2018: member

    Maybe it helps if you include the diffoscope output between two consecutive builds?

  51. ken2812221 commented at 7:58 PM on August 30, 2018: contributor

    Yes, I know it contains current timestamp and checksum, that is the only differnece. But I don't know why it would be there. I already pack scons into faketime wrapper.

  52. ken2812221 commented at 10:06 AM on August 31, 2018: contributor

    The difference is here: https://0bin.net/paste/Z5FvTgDDCLs2El3y#fvLayra1H9pE-R0lc/QX026USa0ZYn5PgTWKDCFqkT5

    Apparently it is timestamp.

  53. MarcoFalke commented at 1:18 PM on August 31, 2018: member

    Could you also upload both of the tar.gz results?

  55. ken2812221 renamed this:
    wip, depends: Add native_nsis to support unicode
    [WIP] depends: Add native_nsis to support unicode
    on Sep 11, 2018
  56. ken2812221 commented at 6:53 AM on September 16, 2018: contributor

    Close it for now. I can't solve the gitian build deterministic issue.

  57. ken2812221 closed this on Sep 16, 2018
  58. ken2812221 deleted the branch on Sep 16, 2018
  59. fanquake added the label Up for grabs on Sep 16, 2018
  60. MarcoFalke commented at 1:53 PM on September 16, 2018: member

    Oh, wait. Why is it required that the depends cache is deterministic? Shouldn't the only requirement be that the resulting bitcoind.exe (et al) is deterministic? At least that should be the goal when we want to support deterministic builds on any host by default.

    If you reopen, I can run DrahtBot on this twice to see what the effective difference is for Gitian builds.

  61. ken2812221 restored the branch on Sep 16, 2018
  62. ken2812221 commented at 4:20 PM on September 16, 2018: contributor

    Why is it required that the depends cache is deterministic?

    It has to compile installer and decompressor that runs on Windows.

    If you reopen, I can run DrahtBot on this twice to see what the effective difference is for Gitian builds.

    Thanks, but you have to clear nsis depends cache manually, otherwise it's deterministic.

  63. ken2812221 reopened this on Sep 16, 2018
  64. DrahtBot added the label Needs rebase on Oct 26, 2018
  65. DrahtBot commented at 1:19 PM on October 26, 2018: member

    <!--cf906140f33d8803c4a75a2196329ecb-->Needs rebase

  66. ken2812221 closed this on Oct 26, 2018
  67. ken2812221 deleted the branch on Oct 26, 2018
  68. laanwj removed the label Needs rebase on Oct 24, 2019
  69. MarcoFalke commented at 2:05 PM on February 6, 2020: member

    Does this upstream patch fix this? https://sourceforge.net/p/nsis/bugs/1230/

  70. fanquake removed the label Up for grabs on Mar 2, 2021
  71. fanquake commented at 8:55 AM on March 2, 2021: member

    Removing "Up for grabs", as this should be taken care of by #21333.

  72. DrahtBot locked this on Aug 16, 2022
Contributors
ken2812221fanquakeDrahtBotMarcoFalkelaanwj
Labels
WindowsBuild system

Milestone
0.18.0

Linked (view graph)
#8825 NSIS 3 released#13817 NSIS: Error launching the installer when login name contains some non-ascii characters#13869 Filename and command line encoding issue on Windows
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 03:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me