[tests] Fix p2p_sendheaders race #13522

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:p2p_sendheaders_race changing 1 files +2 −0
  1. jnewbery commented at 3:59 pm on June 22, 2018: member

    p2p_sendheaders has a race in part 1.3.

    part 1.2 sends a block to the node over the ’test_node’ connection, but doesn’t wait for an inv to be received on the ‘inv_node’ connection. If we get to part 1.3 before that inv has been received, then the subsequent call to check_last_inv_announcement could fail.

  2. [tests] Fix p2p_sendheaders race
    p2p_sendheaders has a race in part 1.3.
    
    part 1.2 sends a block to the node over the 'test_node' connection, but
    doesn't wait for an inv to be received on the 'inv_node' connection. If
    we get to part 1.3 before that inv has been received, then the
    subsequent call to check_last_inv_announcement could fail.
    75848bcf40
  3. fanquake added the label Tests on Jun 22, 2018
  4. MarcoFalke commented at 4:44 pm on June 22, 2018: member
    utACK 75848bcf401a23672aaec1d8be2738443946808c
  5. fanquake commented at 8:35 am on July 1, 2018: member
    utACK 75848bc
  6. MarcoFalke merged this on Jul 1, 2018
  7. MarcoFalke closed this on Jul 1, 2018

  8. MarcoFalke referenced this in commit 686e97a0c7 on Jul 1, 2018
  9. jnewbery deleted the branch on Jul 2, 2018
  10. scravy referenced this in commit ea638d67f7 on Mar 11, 2019
  11. codablock referenced this in commit af97ea2242 on Apr 18, 2020
  12. UdjinM6 referenced this in commit 08477899b4 on Apr 19, 2020
  13. ckti referenced this in commit a4c7c851a8 on Mar 28, 2021
  14. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me