WIP: Drop unused serialization support from CAddresss #13560

1. 
   Empact commented at 6:57 am on June 28, 2018: member

   Seems serialization is now taking place via CAddrInfo.
2. Drop unused serialization support from CAddresss 4b0c4b59fa
3. 
   Empact commented at 8:08 am on June 28, 2018: member

   I’m guessing the test failures are a sign that my assumption that successfully building without the serialization functionality is not sufficient evidence that they’re unused… TBD.
4. Empact renamed this:
   Drop unused serialization support from CAddresss
   WIP: Drop unused serialization support from CAddresss
   on Jun 28, 2018
5. Empact closed this on Jun 28, 2018

   ---

6. Empact deleted the branch on Jun 28, 2018
7. 
   sipa commented at 8:42 am on June 28, 2018: member

   CAddress serialization is at least used inside “addr” and “version” messages on the network. By removing its serializers, those instances end up invoking the superclass’s serializers (CNetAddr).
8. 
   Empact commented at 1:34 pm on June 28, 2018: member

   Thanks, yeah I realized that over the course of the night. One project I think is interesting would be to separate out the CNetAddr/CAddress/CService/CAddrInfo/etc into a composition-based relationship rather than an inheritance-based one, because the aggregate is pretty broad. May push something up to that effect down the line.
9. MarcoFalke locked this on Sep 8, 2021

Contributors
Empact sipa