Seems serialization is now taking place via CAddrInfo.
WIP: Drop unused serialization support from CAddresss #13560
pull Empact wants to merge 1 commits into bitcoin:master from Empact:caddress-serialization changing 1 files +0 −19-
Empact commented at 6:57 AM on June 28, 2018: member
-
Drop unused serialization support from CAddresss 4b0c4b59fa
-
Empact commented at 8:08 AM on June 28, 2018: member
I'm guessing the test failures are a sign that my assumption that successfully building without the serialization functionality is not sufficient evidence that they're unused... TBD.
- Empact renamed this:
Drop unused serialization support from CAddresss
WIP: Drop unused serialization support from CAddresss
on Jun 28, 2018 - Empact closed this on Jun 28, 2018
- Empact deleted the branch on Jun 28, 2018
-
sipa commented at 8:42 AM on June 28, 2018: member
CAddress serialization is at least used inside "addr" and "version" messages on the network. By removing its serializers, those instances end up invoking the superclass's serializers (CNetAddr).
-
Empact commented at 1:34 PM on June 28, 2018: member
Thanks, yeah I realized that over the course of the night. One project I think is interesting would be to separate out the CNetAddr/CAddress/CService/CAddrInfo/etc into a composition-based relationship rather than an inheritance-based one, because the aggregate is pretty broad. May push something up to that effect down the line.
- MarcoFalke locked this on Sep 8, 2021
