test: Fix AreInputsStandard test to reference the proper scriptPubKey #13565

1. 
   Empact commented at 6:43 PM on June 28, 2018: member

   This value doesn't affect the outcome of the test, because the values are properly set on line 351 (https://github.com/bitcoin/bitcoin/pull/13565/files#diff-b7061098b41bd31ef5db043705441133R351), but this makes the test values internally coherent.

2. Fix AreInputsStandard test to reference the proper scriptPubKey

   This value doesn't affect the outcome of the test, because the values are
   properly set on line 351, but this makes the test values internally coherent.

   f95989b3ed
3. 
   Empact commented at 6:45 PM on June 28, 2018: member

   Alternatively, if there's a way to remove this apparently ineffectual reference, I'd be curious to hear it.

4. Empact renamed this:
   Fix AreInputsStandard test to reference the proper scriptPubKey
   test: Fix AreInputsStandard test to reference the proper scriptPubKey
   on Jun 28, 2018
5. fanquake added the label Tests on Jun 28, 2018
6. laanwj requested review from theuni on Jul 5, 2018
7. 
   laanwj commented at 6:52 PM on July 5, 2018: member

   Adding @theuni as reviewer as he touched this line last.

8. 
   theuni commented at 5:37 PM on July 6, 2018: member

   Looks like it's been this way since introduction in 7f3b4e95695d50a4970e6eb91faa956ab276f161. I'm confused about why this works as-is though, am I missing something obvious?

9. 
   MarcoFalke commented at 2:22 PM on July 10, 2018: member

   It works as is, because the check is done on the redeemScript derived from the scriptSig sixteenSigops and not on the scriptPubKey of the coin.

10. 
    MarcoFalke commented at 2:22 PM on July 10, 2018: member

    utACK f95989b3ed864e2c2293958711da03e84e83a95e

11. MarcoFalke merged this on Jul 10, 2018
12. MarcoFalke closed this on Jul 10, 2018

    ---

13. MarcoFalke referenced this in commit b05ded1764 on Jul 10, 2018
14. Empact deleted the branch on Jul 10, 2018
15. deadalnix referenced this in commit f04619aba4 on Apr 10, 2020
16. PastaPastaPasta referenced this in commit b9e0fe112a on Jul 9, 2020
17. PastaPastaPasta referenced this in commit 6e5fed036d on Jul 9, 2020
18. ftrader referenced this in commit 28d5fc9a71 on Aug 17, 2020
19. MarcoFalke locked this on Sep 8, 2021

Contributors

EmpactlaanwjtheuniMarcoFalke

Review Requested
theuni