Audit string.h inclusion #13584

1. 
   Empact commented at 10:22 pm on July 1, 2018: member

   • Prefer cstddef over cstring for size_t definition - fewer overall definitions
   • Include cstring where used, and note which definitions are used

   Fixes #13581

2. Prefer cstddef over string.h for size_t definition

   Fewest overall definitions of the headers which provide it.

   4f986e6944
3. Include cstring where used, and note which definitions are used a505ca9d8b
4. Empact force-pushed on Jul 1, 2018
5. fanquake added the label Refactoring on Jul 1, 2018
6. 
   Empact commented at 5:41 pm on July 2, 2018: member

   ~Closing in favor of future / more targeted work~
7. Empact closed this on Jul 2, 2018

   ---

8. Empact reopened this on Jul 9, 2018

   ---

9. 
   Empact commented at 10:01 pm on July 9, 2018: member

   Ran this through iwyu to confirm computationally that the relevant files were being locally referenced. See the output for master: https://gist.githubusercontent.com/Empact/889c787e1d9d45656d6cdfa2de6a917d/raw/fb1793cf4cd003d0ab0f196dd5c698451dc6290f/iwyu_master And this PR: https://gist.githubusercontent.com/Empact/889c787e1d9d45656d6cdfa2de6a917d/raw/fb1793cf4cd003d0ab0f196dd5c698451dc6290f/iwyu_cstring

   Note the changes were identified independent of iwyu, via grepping.

10. 
    DrahtBot commented at 11:10 pm on July 9, 2018: member

    • #13177 (GCC-7 and glibc-2.27 back compat code by ken2812221)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. 
    Empact commented at 4:44 am on July 11, 2018: member

    Even given the iwyu logs, I’m doubting this is worth the review effort. Closing again!
12. Empact closed this on Jul 11, 2018

    ---

13. MarcoFalke locked this on Sep 8, 2021

Contributors
Empact DrahtBot

Labels
Refactoring