Include cstring alongside select in compat/glib_sanity.cpp #13619

1. 
   Empact commented at 10:04 pm on July 9, 2018: member

   At least SmartOS implements FD_ZERO relative to memset but does not ensure its availability. Including cstring fixes that.
2. 
   Empact commented at 10:05 pm on July 9, 2018: member

   Should fix #13581. @stacepellegrino are you up for building this branch?
3. Empact force-pushed on Jul 9, 2018
4. Include cstring alongside select in compat/glib_sanity.cpp

   At least SmartOS implements FD_ZERO relative to memset but does not
   ensure its availability. Including cstring fixes that.

   503f85a3e9
5. Empact force-pushed on Jul 9, 2018
6. Empact renamed this:
   Inlcude cstring rather than cstddef in compat/glib_sanity.cpp
   Include cstring alongside select in compat/glib_sanity.cpp
   on Jul 9, 2018
7. 
   Empact commented at 10:29 pm on July 9, 2018: member

   Alternatively we could include cstring all the time and drop the extern definition for memcpy. /cc @theuni 679240d0e9
8. 
   Empact commented at 6:39 am on July 10, 2018: member

   Closing this since I’m doubting #13581 now.
9. Empact closed this on Jul 10, 2018

   ---

10. Empact reopened this on Jul 11, 2018

    ---

11. 
    theuni commented at 8:22 pm on July 11, 2018: member

    Yes, this is not correct. We’re attempting to replace memcpy, so including cstring is not the right thing to do. I’ll comment further on #13581.
12. 
    Empact commented at 6:15 pm on July 13, 2018: member

    Closing as per #13581 (comment)
13. Empact closed this on Jul 13, 2018

    ---

14. Empact deleted the branch on Jul 13, 2018
15. laanwj referenced this in commit dd8cf82e96 on Sep 18, 2019
16. sidhujag referenced this in commit f5f7b1e08e on Sep 23, 2019
17. MarcoFalke locked this on Sep 8, 2021

Contributors
Empact theuni