Free keystore.h from file scope level type aliases #13627

1. 
   l2a5b1 commented at 10:44 PM on July 10, 2018: contributor

   This pull request frees keystore.h from type alias declarations that have been declared at file scope level.

   keystore.h has various type aliases that have been declared ~3 - 6 years ago at file scope level, which can either be encapsulated or removed.

   Where type alias declarations are encapsulated at the appropriate scope and access level, C++11's using notation is used in favor of the typedef notation.

2. fanquake requested review from sipa on Jul 11, 2018
3. fanquake added the label Refactoring on Jul 11, 2018
4. 
   Empact commented at 8:08 AM on July 11, 2018: member

   utACK 8d08a75 maybe squash the type alias commits

5. 
   DrahtBot commented at 12:06 PM on July 11, 2018: member

   <!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:

   • #13114 (wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore by practicalswift)
   • #11634 (wallet: Add missing cs_wallet/cs_KeyStore locks to wallet by practicalswift)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   laanwj commented at 6:32 PM on July 11, 2018: member

   utACK 8d08a756d39cbb486c8206a7007ae9790800fc4b, as the aliases aren't to be used used outside the class I also think defining them inside the class is more elegant.

7. 
   MarcoFalke commented at 6:37 PM on July 11, 2018: member

   utACK 8d08a75

8. 
   MarcoFalke commented at 7:14 PM on July 11, 2018: member

   Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

9. l2a5b1 force-pushed on Jul 11, 2018
10. 
    l2a5b1 commented at 10:33 PM on July 11, 2018: contributor

    Thanks for the feedback! Squashed in 6d69090.

11. DrahtBot added the label Needs rebase on Jul 11, 2018
12. Refactors `keystore.h` type aliases.

    This squashed commit either encapsulates type alias declarations at the appropriate scope; or removes type aliases that are not used.
    
    The encapsulated type aliases are declared using C++11's `using` notation in favor of the `typedef` notation.

    d0b9405f96
13. l2a5b1 force-pushed on Jul 11, 2018
14. 
    l2a5b1 commented at 11:14 PM on July 11, 2018: contributor

    Rebased for 5ba77df in d0b9405.

15. DrahtBot removed the label Needs rebase on Jul 12, 2018
16. 
    MarcoFalke commented at 1:23 AM on July 12, 2018: member

    utACK d0b9405f964670d6eaa8529f65fa7993b2a406c8

17. 
    Empact commented at 2:37 AM on July 12, 2018: member

    re-utACK d0b9405

18. laanwj merged this on Jul 12, 2018
19. laanwj closed this on Jul 12, 2018

    ---

20. laanwj referenced this in commit 9b638c7ce1 on Jul 12, 2018
21. jasonbcox referenced this in commit ff2d6930d8 on Dec 20, 2019
22. jonspock referenced this in commit 3089d9be6d on Oct 2, 2020
23. jonspock referenced this in commit 0782ab59ac on Oct 5, 2020
24. jonspock referenced this in commit 6575d9608a on Oct 10, 2020
25. PastaPastaPasta referenced this in commit f2d992b88e on Dec 16, 2020
26. PastaPastaPasta referenced this in commit 60d39e6b14 on Dec 18, 2020
27. PastaPastaPasta referenced this in commit 672beb2179 on Dec 18, 2020
28. MarcoFalke locked this on Sep 8, 2021

Review Requested
sipa