gitian-build.sh cleanup #13628

pull dongcarl wants to merge 3 commits into bitcoin:master from dongcarl:gitian-build-cleanup changing 1 files +194 −216

dongcarl commented at 12:43 AM on July 11, 2018: member
- Add build() bash function
- Simplify and DRYify all steps
- Conform to shellcheck
- Fix insane whitespacing
fanquake added the label Scripts and tools on Jul 11, 2018
fanquake added the label Build system on Jul 11, 2018
fanquake removed the label Scripts and tools on Jul 11, 2018
DRYify gitian-build.sh ed8cb7d7f0
dongcarl force-pushed on Jul 11, 2018
Whitespace fixes. 2a6150dc27
dongcarl force-pushed on Jul 11, 2018
gitian-build.sh: Conform to shellcheck, improve robustness 8df0cb393d
dongcarl renamed this:
~~DRYify gitian-build.sh~~
gitian-build.sh cleanup
on Jul 11, 2018
Empact commented at 8:11 AM on July 11, 2018: member

How about starting with just the shellcheck commit, and maybe pairing it with a shellcheck test/linter? Just a suggestion.
laanwj commented at 10:47 AM on July 11, 2018: member

I'm afraid this PR is redundant due to #13623, which ports the script to Python. Please help reviewing and testing that one instead.
DrahtBot commented at 12:06 PM on July 11, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #13623 (Migrate gitian-build.sh to python by ken2812221)
- #13171 (Change gitian-descriptors to use bionic instead by ken2812221)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
dongcarl closed this on Jul 11, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels