ui is one of the modules that poison other modules with boost/signals2 headers. This moves the include to the cpp file and uses a forward declaration in the header.
Locally this speeds up the incremental build (building everything that uses the ui module) with gcc by ~5% for me. Gcc uses ~5% less memory.
Would be nice if someone could verify the numbers roughly.
I presume the improvements will be more pronounced if the other models would stop exposing the boost header as well.
Concept ACK.
Though, I wonder if we do this, it would make sense to move this away from boost::signals completely for the UI interface (registering interface objects as delegates instead) instead of working to hide boost::signals. But no strong opinion on that.
74@@ -72,43 +75,69 @@ class CClientUIInterface
75 MSG_ERROR = (ICON_ERROR | BTN_OK | MODAL)
76 };
77
78+#define ADD_SIGNALS_DECL_WRAPPER(signal_name) \
79+ boost::signals2::connection signal_name##_connect(std::function<signal_name##Sig> fn); \
80+ void signal_name##_disconnect(std::function<signal_name##Sig> fn);
; to avoid ;; when used
81+
82 /** Show message box. */
83- boost::signals2::signal<bool (const std::string& message, const std::string& caption, unsigned int style), boost::signals2::last_value<bool> > ThreadSafeMessageBox;
84+ bool ThreadSafeMessageBox (const std::string& message, const std::string& caption, unsigned int style);
85+ using ThreadSafeMessageBoxSig = bool(const std::string& message, const std::string& caption, unsigned int style);
86+ ADD_SIGNALS_DECL_WRAPPER(ThreadSafeMessageBox);
Maybe overkill but
0#define ADD_SIGNALS_DECL_WRAPPER(signal_name, rtype, args...) \
1 rtype signal_name(args);\
2 using signal_name##Sig = rtype(args);\
3 [...]
then e.g.
0 ADD_SIGNALS_DECL_WRAPPER(ThreadSafeMessageBox, bool, const std::string& message, const std::string& caption, unsigned int style);
