[moveonly] Extract CWallet::MarkInputsDirty, and privatize AddToWalletIfInvolvingMe #13651

1. 
   Empact commented at 8:26 pm on July 12, 2018: member

   Thus reducing code and surface area of CWallet.
2. fanquake added the label Wallet on Jul 12, 2018
3. in src/wallet/wallet.h:707 in de381c6c9b outdated

   702@@ -703,9 +703,27 @@ class CWallet final : public CCryptoKeyStore, public CValidationInterface
   703     void AddToSpends(const COutPoint& outpoint, const uint256& wtxid);
   704     void AddToSpends(const uint256& wtxid);
   705 
   706+    /**
   707+     * Add a transaction to the wallet, or update it.  pIndex and posInBlock should
   

   ---

   ---

   

   promag commented at 2:25 pm on July 13, 2018:

   ... if belongs to the wallet?

   ---

   

   Empact commented at 4:39 pm on July 13, 2018:

   Going to leave as moveonly.
4. 
   promag commented at 2:36 pm on July 13, 2018: member

   utACK de381c6.
5. Empact renamed this:
   Extract CWallet::MarkInputsDirty, and privatize AddToWalletIfInvolvingMe
   [moveonly] Extract CWallet::MarkInputsDirty, and privatize AddToWalletIfInvolvingMe
   on Jul 13, 2018
6. 
   DrahtBot commented at 7:22 pm on July 13, 2018: member

   • #13658 ([wallet] [moveonly] Move rescanning from time logic into wallet/rpcdump.cpp by Empact)
   • #11634 (wallet: Add missing cs_wallet/cs_KeyStore locks to wallet by practicalswift)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   DrahtBot commented at 7:43 pm on July 13, 2018: member
8. DrahtBot added the label Needs rebase on Jul 13, 2018
9. Extract CWallet::MarkInputsDirty

   To avoid repeated implementations.

   b7f5650942
10. Privatize CWallet::AddToWalletIfInvolvingMe

    And document in the header.

    17e6aa8e33
11. Empact force-pushed on Jul 13, 2018
12. 
    Empact commented at 8:20 pm on July 13, 2018: member

    Rebased for #12944
13. 
    promag commented at 8:37 pm on July 13, 2018: member

    (re)utACK 17e6aa8.
14. 
    sipa commented at 10:01 pm on July 13, 2018: member

    utACK 17e6aa8e333dbf3631fb09dc6eb7ede1937269df
15. 
    MarcoFalke commented at 0:15 am on July 14, 2018: member

    utACK 17e6aa8
16. sipa merged this on Jul 14, 2018
17. sipa closed this on Jul 14, 2018

    ---

18. sipa referenced this in commit 1329ef1f00 on Jul 14, 2018
19. Empact deleted the branch on Jul 14, 2018
20. laanwj removed the label Needs rebase on Oct 24, 2019
21. UdjinM6 referenced this in commit df5018c609 on Jun 29, 2021
22. UdjinM6 referenced this in commit f4b1dbd662 on Jun 29, 2021
23. UdjinM6 referenced this in commit e7ce358a40 on Jul 1, 2021
24. UdjinM6 referenced this in commit 0629f2c57a on Jul 2, 2021
25. UdjinM6 referenced this in commit f7bbcabba9 on Jul 2, 2021
26. DrahtBot locked this on Dec 16, 2021

Contributors
Empact promag DrahtBot sipa MarcoFalke

Labels
Wallet