GUI: change verifymessagepage behaviour to match RPC-call "verifymessage" #1368

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:verifymessagepage changing 4 files +105 −80
  1. Diapolo commented at 12:17 PM on May 21, 2012: none
    • change verifymessagepage behaviour to match RPC-call "verifymessage" (input address, signature and message)
    • remove "copy to clipboard" button as that is unneeded now
    • re-positioned the status label
    • display (error / info) messages in status label (remove message boxes)
    • resize window to make signature fully readable
    • change signature font to BC-address font (like in messagepage)
    • remove checkAddress() and place code directly in on_verifyMessage_clicked()
    • add visual feedback to LineEdits
    • remove AddressTableModel references
    • add addr.GetKeyID(keyID) check

    This addresses #1356.

  2. laanwj commented at 5:13 PM on May 21, 2012: member

    Looks good.

    One comment: you have two error feedback mechanisms now. One that pops up a message box (ie, when the address is wrong or when it cannot decode the signature) and one that shows a red message in the window itself. I like the second one better. Can you use it for all errors?

  3. Diapolo commented at 5:21 PM on May 21, 2012: none

    I guess that should not be a problem, will try how that looks and update :), good point!

  4. laanwj commented at 6:54 AM on May 22, 2012: member

    I just thought about it a bit, and I guess it'd be nicest to pop up a tooltip at the widget that contains invalid input, on validation error. Maybe even a special "error" tooltip (if possible).

    We could use the same in the send coins entries. Currently, invalid fields are colored red there on error, but there is no feedback message.

    No need to implement in this commit though. It probably requires some extra infrastructure.

  5. Diapolo commented at 6:55 AM on May 22, 2012: none

    Updated to use the status label for (info / warning / error) message display and resized the window to see the full signature (use BC-address font for display).

  6. Diapolo commented at 6:58 AM on May 22, 2012: none

    @laanwj I would like to get this on meged (when final), as your suggestion requires a change to this ui-element and others. Can you show me a screen of how you think of that tooltip ... I currently have not imagination, how that would look :).

  7. laanwj commented at 7:06 AM on May 22, 2012: member

    Just a temporary message that points to the field, and that goes away as soon as you click (or after a while). .. you see this commonly on web forms.

  8. Diapolo commented at 7:10 AM on May 22, 2012: none

    Alright, yes I know what you are talking about ... I like those. We should look how to do them :). Any further suggestions for this commit here, did you try it out?

  9. laanwj commented at 4:39 PM on May 22, 2012: member

    ACK

  10. sipa commented at 9:04 PM on May 22, 2012: member

    @gmaxwell maybe you want to comment on this?

  11. Diapolo commented at 2:36 PM on May 27, 2012: none

    Rebased and updated to work after #1357 got merged.

  12. Diapolo commented at 8:51 PM on May 28, 2012: none

    Updated once more, removed checkAddress() and placed code directly in on_verifyMessage_clicked() function. @gmaxwell Can you comment please :)?

  13. Diapolo commented at 9:18 AM on May 31, 2012: none

    Can another dev, who uses the GUI, please verify this is okay? I have another commit that depends on this one ... any reason not to merge this? Sometimes it takes a little long to get "small" changes in ;).

  14. Diapolo commented at 8:03 PM on May 31, 2012: none

    Updated to add visual feedback to LineEdits via QValidatedLineEdit class. Any other dev except @laanwj (who is not here currently), who can try this and comment?

  15. Diapolo commented at 8:31 PM on May 31, 2012: none

    Updated to remove AddressTableModel references, as they are now unused.

  16. Diapolo commented at 8:33 AM on June 1, 2012: none

    Updated to resolve a small glitch with the visual feedback (QEvent::FocusIn would not reach QValidatedLineEdit::focusInEvent).

  17. change verifymessagepage behaviour to match RPC-call "verifymessage" (input address, signature and message) / display messages in status label (remove message boxes) / resize window to make signature fully readable / change signature font to BC-address font (like in messagepage) / remove checkAddress() and place code directly in on_verifyMessage_clicked() / add visual feedback to LineEdits / remove AddressTableModel references, as they are now unused / add addr.GetKeyID(keyID) check 8103b0bb62
  18. Diapolo commented at 9:15 AM on June 1, 2012: none

    Updated to add addr.GetKeyID(keyID) check.

  19. laanwj commented at 10:26 AM on June 1, 2012: member

    Ack

  20. Diapolo commented at 10:37 AM on June 1, 2012: none

    @laanwj Great to see you here :)!

  21. laanwj referenced this in commit 88d7bc930a on Jun 2, 2012
  22. laanwj merged this on Jun 2, 2012
  23. laanwj closed this on Jun 2, 2012
  24. coblee referenced this in commit e258bba580 on Jul 17, 2012
  25. lateminer referenced this in commit b614dd3458 on Jan 22, 2019
  26. lateminer referenced this in commit d610d013dd on May 6, 2020
  27. DrahtBot locked this on Feb 15, 2022
Contributors
Diapololaanwjsipa
Linked (view graph)
#1356 Verify Message provides the address
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 18:16 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me