Update cross compilation dependencies for Bionic, clarify depends usage #13702

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2018/07/bionic-depends-docs changing 2 files +10 −3

Sjors commented at 10:36 am on July 18, 2018: member

Bionic apt-get install can’t find the g++-4.8* packages.

When using the depends system for your own host, you don’t need to install: libssl-dev libevent-dev libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev.
Update cross compilation dependencies for Bionic, clarify depends usage 847f11fa1f
fanquake added the label Docs on Jul 18, 2018
fanquake added the label Build system on Jul 18, 2018
laanwj commented at 11:19 am on July 18, 2018: member

Bionic apt-get install can’t find the g++-4.8* packages.

I wonder why it recommends getting the gcc-4.8 packages at all. What is preferable about forcing a certain version?

in doc/build-unix.md:77 in 847f11fa1f

71@@ -72,6 +72,10 @@ Build requirements:
72 
73     sudo apt-get install build-essential libtool autotools-dev automake pkg-config libssl-dev libevent-dev bsdmainutils python3 libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev
74 
75+Build requirements if you use the [depends system](/depends/README.md):
76+
77+    sudo apt-get install build-essential libtool autotools-dev automake pkg-config python3 bsdmainutils

MarcoFalke commented at 11:23 am on July 18, 2018:

Wouldn’t those instructions better be suited in the depends readme?

Sjors commented at 11:58 am on July 18, 2018:

The depends README currently shows which apt packages to install specifically for those depends. The items here are for the main application.

in depends/README.md:50 in 847f11fa1f
44@@ -43,7 +45,9 @@ For Win32/Win64 cross compilation: 45 46 For linux (including i386, ARM) cross compilation: 47 48- sudo apt-get install curl g++-aarch64-linux-gnu g++-4.8-aarch64-linux-gnu gcc-4.8-aarch64-linux-gnu binutils-aarch64-linux-gnu g++-arm-linux-gnueabihf g++-4.8-arm-linux-gnueabihf gcc-4.8-arm-linux-gnueabihf binutils-arm-linux-gnueabihf g++-4.8-multilib gcc-4.8-multilib binutils-gold bsdmainutils 49+ sudo apt-get install curl g++-arm-linux-gnueabihf g++-aarch64-linux-gnu \ 50+ binutils-arm-linux-gnueabihf binutils-aarch64-linux-gnu \ 51+ g++-4.8-multilib gcc-4.8-multilib binutils-gold
MarcoFalke commented at 11:26 am on July 18, 2018:

Shouldn’t the version be 7, similar to what is mentioned in the gitian descriptor?

Sjors commented at 11:59 am on July 18, 2018:

The version of what?

MarcoFalke commented at 1:02 pm on July 18, 2018:

Sorry for the ellipsis. I meant the version of the packages that are mentioned in the line I commented on.

See the gitian descriptor: https://github.com/ken2812221/bitcoin/blob/c1afe3232fa10e290fb355cf37ea4c7bc1084065/contrib/gitian-descriptors/gitian-linux.yml#L19

Sjors commented at 4:27 pm on August 1, 2018:

I have no idea what the right choice is, welcome more thoughts…

MarcoFalke commented at 9:39 pm on August 1, 2018:

I guess the right choice is to remove the explicit mention of versions everywhere.

MarcoFalke commented at 6:29 pm on August 16, 2018:

So apparently you can’t do it in one go, due to https://bugs.launchpad.net/ubuntu/+source/gcc-defaults-arm64-cross/+bug/1347820

But splitting the apt-get into two commands (one for gcc-multilib) and the other for the rest (with their versions removed) should work.

MarcoFalke commented at 6:18 pm on September 9, 2018:

You could work around these by splitting the installation into the common dependencies apt install curl g++-multilib binutils-gold. And then a separate command for apt install g++-arm-linux-gnueabihf g++-aarch64-linux-gnu \ binutils-arm-linux-gnueabihf binutils-aarch64-linux-gnu \
DrahtBot closed this on Sep 7, 2018
DrahtBot commented at 9:00 pm on September 7, 2018: member
DrahtBot reopened this on Sep 7, 2018
laanwj commented at 6:48 am on September 11, 2018: member

I wonder why it recommends getting the gcc-4.8 packages at all.

I still don’t understand why this guide recommends getting gcc 4.8 versions specifically.

4.8 is old as the hills I don’t remember ever needing this.
fanquake commented at 3:16 am on September 19, 2018: member

Closing in favour of #14264.
fanquake closed this on Sep 19, 2018
DrahtBot commented at 3:31 am on September 19, 2018: member
- #14264 (doc: Split depends installation instructions per arch by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot locked this on Sep 8, 2021

Contributors
Sjors laanwj MarcoFalke DrahtBot fanquake

Labels
Docs Build system