tests: Add usage note to check-rpc-mappings.py #13707

pull masonicboom wants to merge 1 commits into bitcoin:master from masonicboom:add-usage-note-to-check-rpc-mappings changing 1 files +4 −0

masonicboom commented at 12:49 AM on July 19, 2018: none

This test would previously fail without a user-friendly warning message, if invoked with no arguments.

Test plan:

bitcoin @_@$ python3 test/lint/check-rpc-mappings.py
Usage: test/lint/check-rpc-mappings.py ROOT-DIR
bitcoin @_@$ echo $?
1
bitcoin @_@$ python3 test/lint/check-rpc-mappings.py .
* Checking consistency between dispatch tables and vRPCConvertParams
bitcoin @_@$ echo $?
0

fanquake added the label Tests on Jul 19, 2018
masonicboom renamed this:
~~Tests: add usage note to check-rpc-mappings.py~~
tests: add usage note to check-rpc-mappings.py
on Jul 19, 2018
masonicboom renamed this:
~~tests: add usage note to check-rpc-mappings.py~~
tests: Add usage note to check-rpc-mappings.py
on Jul 19, 2018
Tests: add usage note to check-rpc-mappings.py 03a2d68010

in test/lint/check-rpc-mappings.py:94 in 6dc0877bfa outdated

  89 | @@ -90,6 +90,10 @@ def process_mapping(fname):
  90 |      return cmds
  91 |  
  92 |  def main():
  93 | +    if len(sys.argv) != 2:
  94 | +        print(('Usage: %s ROOT-DIR' % sys.argv[0]), file=sys.stderr)

practicalswift commented at 7:40 AM on July 19, 2018:

Nit: Remove redundant parentheses around ' and use .format(…).

masonicboom force-pushed on Jul 19, 2018
MarcoFalke referenced this in commit f7f574d453 on Jul 20, 2018
laanwj commented at 8:41 PM on August 25, 2018: member

ACK 03a2d680101a9fee47c6fd818df7585cfc93ac06
laanwj merged this on Aug 25, 2018
laanwj closed this on Aug 25, 2018
laanwj referenced this in commit f6eb85d17c on Aug 25, 2018
PastaPastaPasta referenced this in commit 6e5cc92413 on Jul 17, 2020
PastaPastaPasta referenced this in commit 8ad8dbbc2e on Jul 17, 2020
PastaPastaPasta referenced this in commit c0f44834b7 on Jul 17, 2020
Munkybooty referenced this in commit edac135e2d on Jun 15, 2021
PastaPastaPasta referenced this in commit ee5da3b75b on Jun 27, 2021
PastaPastaPasta referenced this in commit 0e10b90b63 on Jun 28, 2021
PastaPastaPasta referenced this in commit 82e1da7bc1 on Jun 29, 2021
PastaPastaPasta referenced this in commit 5bb26d5ae7 on Jun 29, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#13718 docs: Specify preferred Python string formatting technique