depends: use MacOS friendly sed syntax in qt.mk #13750

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2018/07/depends-qt-macos changing 1 files +1 −1

Sjors commented at 10:46 AM on July 24, 2018: member

I just got this error on master:

make clean-all
make -j5
[...]
/bitcoin/depends/sources/qttools-opensource-src-5.9.6.tar.xz: OK
Preprocessing qt...
sed: 1: "qtbase/mkspecs/bitcoin- ...": extra characters at the end of q command
make: *** /bitcoin/depends/work/build/x86_64-apple-darwin17.7.0/qt/5.9.6-b48df1b490b/.stamp_preprocessed] Error 1

fanquake added the label Build system on Jul 24, 2018
Fuzzbawls commented at 10:50 AM on July 24, 2018: contributor

With all these MacOS specific exceptions popping up recently, I almost wonder if it would not be more beneficial to "expect" (or even enforce) brew GNU versions of tools to be installed rather than the archaic pseudo-BSD MacOS versions?
Sjors commented at 10:51 AM on July 24, 2018: member

This line goes away again in #13696 by the way.
Sjors commented at 10:53 AM on July 24, 2018: member

archaic pseudo-BSD MacOS versions

Maybe, but apparently OpenBSB often encounters the same issues (cc @laanwj), so macOS devs help catch problems there this way :-)
fanquake commented at 11:03 AM on July 24, 2018: member
This is not the first time sed has been used in depends, there are already multiple uses in the same file that all work fine on macOS. Something like:
```
sed -i.old "s/arm-linux-gnueabi-/$(host)-/g" qtbase/mkspecs/bitcoin-linux-g++/qmake.conf && \
```
should work fine?
Fuzzbawls commented at 11:07 AM on July 24, 2018: contributor

@fanquake yes, my comment stems from knowing that (in general) there are some differences between MacOS sed and GNU sed...irregardless of wither those differences have ever surfaced here.
Sjors commented at 11:08 AM on July 24, 2018: member

@fanquake I'll try sed -i.old for consistency.
fanquake commented at 11:12 AM on July 24, 2018: member

@Fuzzbawls Sure, sorry if I sounded dismissive. There definitely are some differences, i.e something like #13514 which I stumbled on when playing around with iOS depends builds.
depends: use MacOS friendly sed syntax in qt.mk 12c93cb85b
Sjors force-pushed on Jul 24, 2018
Fuzzbawls commented at 1:09 PM on July 24, 2018: contributor

@fanquake hey no worries mate! I myself don't even know all the (seemingly stupid) differences between MacOS tools and GNU (or even more recent BSD).

I just know there are differences...and those differences may ore may not ever apply here...and if they do...lets make sure they are exclusive to MacOS and exclude them for being archaic (require brew GNU equivilent in this case) rather than cater to such exclusions.
fanquake commented at 10:57 AM on July 25, 2018: member

utACK 12c93cb
MarcoFalke commented at 10:59 AM on July 25, 2018: member

utACK 12c93cb85b6cb075d22323ff02acebbe05e42375
MarcoFalke merged this on Jul 25, 2018
MarcoFalke closed this on Jul 25, 2018
MarcoFalke referenced this in commit c883653202 on Jul 25, 2018
Sjors deleted the branch on Jul 25, 2018
UdjinM6 referenced this in commit e1d8a8c918 on Jul 26, 2020
UdjinM6 referenced this in commit 3f5284b0e4 on Jul 27, 2020
UdjinM6 referenced this in commit 8172157b13 on Jul 27, 2020
PastaPastaPasta referenced this in commit eb578984d3 on Jul 27, 2020
PastaPastaPasta referenced this in commit f8c309ca54 on Jul 28, 2020
CryptoCentric referenced this in commit 75d74afdad on Jul 2, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels