Unhide QT window doesn’t work when hidden with ⌘ + H #13829

issue Sjors openend this issue on August 1, 2018
  1. Sjors commented at 2:22 pm on August 1, 2018: member

    Noticed this while reviewing #13529, but it’s also in master @ 5ba77df. On macOS 10.13.6:

    • Show in the action menu doesn’t work if the app was hidden by Command + H, it does work when hidden through this menu
    • send and receive don’t unhide the window when opened for the action menu. It does navigate to the right tab. The other actions do work (sign, verify & debug window)

    Clicking “Toon” (= macOS native show) does work, suggesting the GUI uses some non-native method of hiding.

  2. fanquake added the label GUI on Aug 1, 2018
  3. redblade7 commented at 1:13 pm on August 18, 2018: none
    I’m not familiar with Mac, but it might be related to #13606
  4. jonasschnelli commented at 1:04 pm on August 30, 2018: contributor

    I can confirm that the action menu “show” doesn’t work when hided with Command + H.

    When hided with the action menu, “send” and “receive” do show the window, but not when used Command + H.

    Fix welcome.

  5. jonasschnelli added the label good first issue on Aug 30, 2018
  6. promag commented at 6:05 pm on August 30, 2018: member

    I can confirm that the action menu “show” doesn’t work when hided with Command + H.

    For me works with Qt 5.11.1 and macOS 10.13.3 at 6c7cfc8da. @Sjors @jonasschnelli which Qt you used?

  7. promag commented at 6:07 pm on August 30, 2018: member

    When hided with the action menu, “send” and “receive” do show the window, but not when used Command + H.

    I also confirm this with Qt 5.11.1 and macOS 10.13.3.

    For me “send” and “receive” never show the window.

    Fix welcome.

    I take this.

  8. promag commented at 1:42 am on August 31, 2018: member
    Similar problems #5880 and #2530.
  9. hebasto commented at 8:03 pm on October 24, 2018: member

    Here are more tests. OS X 10.11.6 (15G22010) + 0.17.0 (Qt 5.9.6)

    Step 1: Dock menu “Hide”

    … some variants of… Step 2: Dock menu “Show” - works as expected: shows main window and brings it to the front.

    Step 2: Dock menu “Send” or “Receive” - does not work: does not show main window at all.

    Step 2: Dock menu “Sign message…” or “Verify message…” - works with some issues: (a) shows main window, (b) shows “sign/verify” window, (c) does not bring any of mentioned windows to the front, (d) makes app icon bounce continuously :) , (e) many items of the Dock menu get greyed.

    Step 2: Dock menu “Debug window” - works as expected: shows both main window and debug window, and brings the latter to the front.

    Moreover, using Command-H or “Hide Bitcoin Core” from the app menu in the Step 1 does not change behaviour.

    UPDATE: also tested on macOS 10.13.6 (17G65) + 0.17.0 (Qt 5.9.6) Results are the same.

  10. hebasto commented at 8:08 pm on October 24, 2018: member
    @fanquake, @jonasschnelli should this issue be labeled “macOS”?
  11. fanquake added the label macOS on Oct 24, 2018
  12. laanwj closed this on Nov 12, 2018

  13. laanwj referenced this in commit 48223256cf on Nov 12, 2018
  14. furszy referenced this in commit 24bc866346 on Apr 13, 2020
  15. 10xcryptodev referenced this in commit 8d279ab3bc on May 14, 2020
  16. michelvankessel referenced this in commit 5e796e2c7f on Oct 25, 2020
  17. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-18 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me