gui: don’t disable the sync overlay when wallet is disabled #13848

1. 
   fanquake commented at 8:24 am on August 2, 2018: member

   When running with -disablewallet the sync modal is now available by clicking on the progress bar or syncing icon.

   Fixes #13828.

2. gui: don't disable the sync overlay when wallet is disabled 68c6fff00d
3. fanquake added the label GUI on Aug 2, 2018
4. fanquake requested review from Sjors on Aug 2, 2018
5. fanquake requested review from jonasschnelli on Aug 2, 2018
6. 
   laanwj commented at 9:56 am on August 2, 2018: member

   I don’t think this message makes much sense when the wallet is disabled? It talks about a wallet and spending coins.
7. 
   DrahtBot commented at 11:14 am on August 2, 2018: member
8. 
   Sjors commented at 11:42 am on August 2, 2018: member

   Concept ACK, though indeed removing the wallet specific warning makes sense.
9. 
   promag commented at 11:05 am on August 3, 2018: member

   FYI in #11826 there is discussion about changing the overlay and I was planning to work on that after 0.17 branch.
10. 
    jonasschnelli commented at 6:57 pm on August 5, 2018: contributor

    I think the modal overlay with the sync-info should show but the warning part (icon / text) should only be visible when a wallet is loaded.
11. Sjors approved
12. 
    Sjors commented at 11:56 am on August 11, 2018: member

    tACK 68c6fff00d5ad3e56f5099048b22ebfd8c793192, it’s a strict improvement over master, despite the unnecessary wallet related text, so would be good to get into 0.17.
13. 
    DrahtBot commented at 10:35 am on August 21, 2018: member
14. DrahtBot added the label Needs rebase on Aug 21, 2018
15. 
    luke-jr commented at 3:21 am on August 26, 2018: member

    Seems like it would be better to just add the missing data to the main Information tab.
16. 
    laanwj commented at 1:21 pm on August 29, 2018: member

    Seems like it would be better to just add the missing data to the main Information tab.

    In principle that’s per-wallet and supposed to have wallet information, not node/global information. That’s why there is no other such information there. Though there would certainly be place for it…

17. 
    fanquake commented at 6:30 am on October 9, 2018: member

    @promag I’m closing and labelling up for grabs. Feel free to work on this.
18. fanquake closed this on Oct 9, 2018

    ---

19. fanquake added the label Up for grabs on Oct 9, 2018
20. fanquake removed the label Needs rebase on Oct 9, 2018
21. fanquake deleted the branch on Jan 3, 2019
22. 
    fanquake commented at 6:46 am on January 3, 2019: member

    Removing up for grabs, as this has been picked up in #15084.
23. fanquake removed the label Up for grabs on Jan 3, 2019
24. jonasschnelli referenced this in commit b9b58f8f68 on Oct 18, 2019
25. sidhujag referenced this in commit 9cc1aa0811 on Oct 18, 2019
26. DrahtBot locked this on Dec 16, 2021

Contributors
fanquake laanwj DrahtBot Sjors promag jonasschnelli luke-jr

Review Requested
jonasschnelli

Labels
GUI