fix locale for lint-shell #13851

1. 
   scravy commented at 12:35 pm on August 2, 2018: contributor

   A piece of code from #13816 which I am hereby splitting into smaller PRs.

   The shellcheck executable shipped with travis’s trusty linux environment (contains shellcheck 0.3.1 in /usr/local/bin as opposed to the distros 0.3.3 in /usr/bin) segfaults when LC_ALL=C.

   This makes sure that in travis, no matter from where the script is called, LC_ALL is left unset. Comment changed accordingly.

2. in test/lint/lint-shell.sh:13 in ac69712e1c outdated

    5@@ -6,6 +6,15 @@
    6 #
    7 # Check for shellcheck warnings in shell scripts.
    8 
    9+# The shellcheck binary segfault/coredumps in Travis with LC_ALL=C
   10+# It does not do so in Ubuntu 14.04, 16.04, 18.04 in versions 0.3.3, 0.3.7, 0.4.6
   11+# respectively. So export LC_ALL=C is set as required by lint-shell-locale.sh
   

   ---

   ---

   

   MarcoFalke commented at 12:38 pm on August 2, 2018:

   Move this comment into the if travis ... ?
3. in test/lint/lint-shell.sh:20 in ac69712e1c outdated

   15+  unset LC_ALL
   16+fi
   17+
   18 # This script is intentionally locale dependent by not setting "export LC_ALL=C"
   19 # to allow running certain versions of shellcheck that core dump when LC_ALL=C
   20 # is set.
   

   ---

   ---

   

   MarcoFalke commented at 12:38 pm on August 2, 2018:

   Remove this comment?

   ---

   

   scravy commented at 12:45 pm on August 2, 2018:

   sure :-X
4. fanquake added the label Tests on Aug 2, 2018
5. fix locale for lint-shell 83c48d9a1f
6. scravy force-pushed on Aug 2, 2018
7. 
   practicalswift commented at 12:56 pm on August 2, 2018: contributor

   utACK 83c48d9a1f15e1531ac7bec0c1440f69ace3ee37

   Nice to get rid of locale dependence for the general non-Travis case! Good work!

8. MarcoFalke renamed this:
   fix locale for lint-shell
   qa: fix locale for lint-shell
   on Aug 2, 2018
9. MarcoFalke renamed this:
   qa: fix locale for lint-shell
   fix locale for lint-shell
   on Aug 2, 2018
10. MarcoFalke merged this on Aug 2, 2018
11. MarcoFalke closed this on Aug 2, 2018

    ---

12. MarcoFalke referenced this in commit 9c4324d866 on Aug 2, 2018
13. scravy deleted the branch on Aug 2, 2018
14. MarcoFalke referenced this in commit ca4510c15d on Aug 27, 2018
15. PastaPastaPasta referenced this in commit e48dd50d6e on Jul 29, 2020
16. PastaPastaPasta referenced this in commit 6e35655b01 on Jul 29, 2020
17. PastaPastaPasta referenced this in commit a859ea12a9 on Jul 29, 2020
18. zkbot referenced this in commit 43ac2062f9 on Oct 28, 2020
19. zkbot referenced this in commit 84a5830aaa on Nov 9, 2020
20. Munkybooty referenced this in commit e1e77958ce on Jun 30, 2021
21. Munkybooty referenced this in commit 17362b8fd4 on Jul 1, 2021
22. Munkybooty referenced this in commit a3a381b28b on Jul 1, 2021
23. Munkybooty referenced this in commit a872c78836 on Jul 2, 2021
24. Munkybooty referenced this in commit 251ce629e7 on Jul 2, 2021
25. Munkybooty referenced this in commit a33cfb7c92 on Jul 4, 2021
26. UdjinM6 referenced this in commit 50d8d8023e on Jul 7, 2021
27. Munkybooty referenced this in commit 9d9efce3f4 on Jul 7, 2021
28. UdjinM6 referenced this in commit 77bbcd9612 on Jul 7, 2021
29. Munkybooty referenced this in commit 1ba72e6323 on Jul 7, 2021
30. Munkybooty referenced this in commit 4c2211dd41 on Jul 8, 2021
31. Munkybooty referenced this in commit 8e25e2f0fe on Jul 8, 2021
32. MarcoFalke locked this on Sep 8, 2021

Contributors
scravy MarcoFalke practicalswift

Labels
Tests