qa: Make extended tests pass on native Windows #13867

pull MarcoFalke wants to merge 4 commits into bitcoin:master from MarcoFalke:Mf1808-qaNodeCloseOutErr changing 3 files +31 −22
  1. MarcoFalke commented at 5:48 PM on August 3, 2018: member

    qa: Close stdout and stderr file when node stops

    Since these files are potentially deleted by the test framework for cleanup, they should be closed first. Otherwise this will lead to errors on Windows when the tests finish successfully.

    Side note: After the patch, it is no longer possible to reopen the file on Windows (see https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile)

    qa: Run gen_rpcauth with sys.executable

    Similar to test_runner.py, the sys.executable needs to be passed down into subprocesses to pass on native Windows. (Should have no effect on Linux)

    qa: Use files for stdout/stderr to support Windows

    It seems that using PIPE is not supported on Windows. Also, it is easier to just use the files that capture the stdout and stderr within the test node class.

  2. qa: Close stdout and stderr file when node stops fada8966c5
  3. MarcoFalke added the label Tests on Aug 3, 2018
  4. qa: Run gen_rpcauth with sys.executable facb56ffaf
  5. MarcoFalke renamed this:
    qa: Close stdout and stderr file when node stops
    qa: Make extended tests pass on Windows
    on Aug 3, 2018
  6. MarcoFalke renamed this:
    qa: Make extended tests pass on Windows
    qa: Make extended tests pass on native Windows
    on Aug 3, 2018
  7. MarcoFalke commented at 8:27 PM on August 3, 2018: member

    This will be recycled into a "Make extended tests pass on native Windows"

  8. MarcoFalke force-pushed on Aug 3, 2018
  9. qa: Use files for stdout/stderr to support Windows faabd7bc47
  10. MarcoFalke force-pushed on Aug 3, 2018
  11. qa: Raise feature_help timeout to 5s fafe73a626
  12. laanwj added the label Windows on Aug 6, 2018
  13. MarcoFalke merged this on Aug 11, 2018
  14. MarcoFalke closed this on Aug 11, 2018

  15. MarcoFalke referenced this in commit 1b04b55f2d on Aug 11, 2018
  16. MarcoFalke deleted the branch on Aug 11, 2018
  17. deadalnix referenced this in commit b025631782 on May 5, 2020
  18. UdjinM6 referenced this in commit 7125874399 on Jul 4, 2021
  19. UdjinM6 referenced this in commit 4a807e8707 on Jul 6, 2021
  20. UdjinM6 referenced this in commit 2972dbb951 on Jul 6, 2021
  21. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 03:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me