Filename and command line encoding issue on Windows #13869

issue ken2812221 openend this issue on August 3, 2018
  1. ken2812221 commented at 7:09 pm on August 3, 2018: contributor

    This issue tracks the TODO list in order to fix the encoding issue on Window.

    Currently Bitcoin Core uses the ANSI encoding on Windows so that it would affected by user’s language settings, they might not able to open some non-ASCII name files.

    You can test all these changes in #13787 (includes leveldb changes)

    Open PRs:

    • Package the Windows installer in unicode mode (NSIS 3+) (#13827, Up for grab, or wait for Ubuntu 20.04 gitian builder host)

    Merged PRs:

    • Create the startup shortcut file in unicode mode (#13734)
    • Make filelock work on unicode filename (#13862)
    • Use _wfopen instead of fopen on Windows to pass unicode filename (#13866)
    • Make boost fs::path .string() to be always encoded to utf-8 (#13877)
    • Wrap ifstream and ofstream to accept unicode filename. (#13878)
    • Get the command line arguments using unicode (#13883)
    • Make bdb read the filename using utf-8 (#13884)
    • Make runCommand works on unicode filename (#13886)
    • Convert all (...)A function to (...)W on Windows if it is related to filename or command line. (#13888)
    • Convert boost filesystem error messages from local multibyte to utf-8 (#14192)
    • Make leveldb read the filename using utf-8 (bitcoin-core/leveldb#18)
  2. ken2812221 renamed this:
    Encoding issue on Windows
    Filenam encoding issue on Windows
    on Aug 3, 2018
  3. ken2812221 renamed this:
    Filenam encoding issue on Windows
    Filename encoding issue on Windows
    on Aug 3, 2018
  4. fanquake added the label Windows on Aug 4, 2018
  5. fanquake added this to the milestone 0.18.0 on Aug 4, 2018
  6. ken2812221 renamed this:
    Filename encoding issue on Windows
    Filename and command line encoding issue on Windows
    on Aug 6, 2018
  7. ken2812221 commented at 7:44 pm on August 30, 2018: contributor
    @sipsorcery @NicolasDorier Mind take a look at this?
  8. NicolasDorier commented at 2:05 am on August 31, 2018: contributor
    Amazing work, ye.
  9. laanwj referenced this in commit f545dfabff on Jan 26, 2019
  10. ken2812221 closed this on Jan 31, 2019

  11. random-zebra referenced this in commit f15a1674ce on Feb 6, 2021
  12. random-zebra referenced this in commit 61a098a775 on Aug 5, 2021
  13. DrahtBot locked this on Dec 16, 2021


ken2812221 NicolasDorier

Labels
Windows

Milestone
0.18.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me