Call unicode API on Windows #13888

1. 
   ken2812221 commented at 1:35 am on August 6, 2018: contributor

   Call Unicode API on Windows
2. laanwj added the label Windows on Aug 6, 2018
3. ken2812221 force-pushed on Aug 11, 2018
4. donaloconnor approved
5. 
   donaloconnor commented at 2:11 pm on August 11, 2018: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/13888/commits/465f3537179ea9445eb75632994fad21a244dc35
6. 
   alexeyneu commented at 9:19 am on August 12, 2018: none

   i doubt that linker will change entry point coz of this . main to wmain change
7. 
   ken2812221 commented at 11:48 am on August 12, 2018: contributor

   @alexeyneu How could that happen?
8. 
   alexeyneu commented at 1:23 pm on August 12, 2018: none

   unicode support means :

   0int wmain(int argc, wchar_t* argv[])
   

   and /ENTRY:wmainCRTStartup in FLAGS . I strongly doubt that latter is added by gcc-msys-winlinux hybrid.
   native unicode .exe makefile:
   https://github.com/alexeyneu/json-demo/blob/master/makefile

9. 
   sipa commented at 6:47 pm on August 12, 2018: member

   @alexeyneu That seems to only affect whether or not command line arguments are passed in as wchar.
10. 
    ken2812221 commented at 9:50 pm on August 12, 2018: contributor

    @alexeyneu You can see #13883 how I solve this. Since we are using mingw. The linker will link wmain only if you pass -municode to it, but I don’t do this.
11. 
    alexeyneu commented at 11:45 pm on August 12, 2018: none

    @ken2812221 yeah it does the trick in msys . I’ve thinkin that you pretend to solve whole issue mentioned @sipa looks like it’s command line related even in msvc
12. ken2812221 force-pushed on Aug 26, 2018
13. Call unicode API on Windows d38bf9105d
14. ken2812221 force-pushed on Sep 11, 2018
15. 
    laanwj commented at 10:09 am on September 13, 2018: member

    utACK d38bf9105d33147c899117a4c20ba7872733186f
16. laanwj merged this on Sep 13, 2018
17. laanwj closed this on Sep 13, 2018

    ---

18. laanwj referenced this in commit 37b836ad09 on Sep 13, 2018
19. ken2812221 deleted the branch on Sep 13, 2018
20. Warrows referenced this in commit a7f5f3228d on Oct 14, 2019
21. Warrows referenced this in commit f5e69c30ac on Nov 23, 2019
22. fanquake deleted a comment on May 10, 2020
23. PastaPastaPasta referenced this in commit 63369d2d83 on Jun 27, 2021
24. PastaPastaPasta referenced this in commit 9be6d3f821 on Jun 28, 2021
25. PastaPastaPasta referenced this in commit b8787d6024 on Jun 29, 2021
26. PastaPastaPasta referenced this in commit 04152daeaa on Jul 1, 2021
27. random-zebra referenced this in commit 61a098a775 on Aug 5, 2021
28. Fabcien referenced this in commit 891d5ad3c1 on Jan 11, 2022
29. DrahtBot locked this on Feb 15, 2022

Contributors
ken2812221 donaloconnor alexeyneu sipa laanwj

Labels
Windows