doc: Revert translated string change, clarify wallet log messages #13911

1. 
   PierreRochard commented at 3:04 pm on August 8, 2018: contributor

   Fixes #12992 post-merge nits from @jnewbery
2. Trivial: Revert translated string change, clarify wallet log messages c4a884d555
3. laanwj added this to the milestone 0.17.0 on Aug 8, 2018
4. fanquake added the label Wallet on Aug 8, 2018
5. 
   jnewbery commented at 3:47 pm on August 8, 2018: member

   LGTM. Tested ACK c4a884d555e75cf43c695517f3f8344be177e5eb
6. 
   DrahtBot commented at 3:56 pm on August 8, 2018: member

   • #10973 (Refactor: separate wallet from node by ryanofsky)
   • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   MarcoFalke commented at 4:47 pm on August 8, 2018: member

   utACK c4a884d555e75cf43c695517f3f8344be177e5eb

   Can confirm that the only changes to translation strings are unrelated to this pull:

    0diff --git a/src/qt/bitcoinstrings.cpp b/src/qt/bitcoinstrings.cpp
    1index ab7e56a9da..de60b30dfe 100644
    2--- a/src/qt/bitcoinstrings.cpp
    3+++ b/src/qt/bitcoinstrings.cpp
    4@@ -40,6 +40,12 @@ QT_TRANSLATE_NOOP("bitcoin-core", ""
    5 "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -"
    6 "fallbackfee."),
    7 QT_TRANSLATE_NOOP("bitcoin-core", ""
    8+"Group outputs by address, selecting all or none, instead of selecting on a "
    9+"per-output basis. Privacy is improved as an address is only used once "
   10+"(unless someone sends to it after spending from it), but may result in "
   11+"slightly higher fees as suboptimal coin selection may result due to the "
   12+"added limitation (default: %u)"),
   13+QT_TRANSLATE_NOOP("bitcoin-core", ""
   14 "Invalid amount for -maxtxfee=<amount>: '%s' (must be at least the minrelay "
   15 "fee of %s to prevent stuck transactions)"),
   16 QT_TRANSLATE_NOOP("bitcoin-core", ""
   17@@ -168,7 +174,7 @@ QT_TRANSLATE_NOOP("bitcoin-core", "Signing transaction failed"),
   18 QT_TRANSLATE_NOOP("bitcoin-core", "Specified -walletdir \"%s\" does not exist"),
   19 QT_TRANSLATE_NOOP("bitcoin-core", "Specified -walletdir \"%s\" is a relative path"),
   20 QT_TRANSLATE_NOOP("bitcoin-core", "Specified -walletdir \"%s\" is not a directory"),
   21-QT_TRANSLATE_NOOP("bitcoin-core", "Specified blocks directory \"%s\" does not exist.\n"),
   22+QT_TRANSLATE_NOOP("bitcoin-core", "Specified blocks directory \"%s\" does not exist."),
   23 QT_TRANSLATE_NOOP("bitcoin-core", "Starting network threads..."),
   24 QT_TRANSLATE_NOOP("bitcoin-core", "The source code is available from %s."),
   25 QT_TRANSLATE_NOOP("bitcoin-core", "The transaction amount is too small to pay the fee"),
   

8. MarcoFalke renamed this:
   Trivial: Revert translated string change, clarify wallet log messages
   doc: Revert translated string change, clarify wallet log messages
   on Aug 8, 2018
9. MarcoFalke added the label Docs on Aug 8, 2018
10. 
    fanquake commented at 0:34 am on August 9, 2018: member

    utACK c4a884d
11. 
    kallewoof commented at 6:40 am on August 9, 2018: member

    utACK c4a884d555e75cf43c695517f3f8344be177e5eb
12. MarcoFalke merged this on Aug 9, 2018
13. MarcoFalke closed this on Aug 9, 2018

    ---

14. MarcoFalke referenced this in commit 3e3a50aeb8 on Aug 9, 2018
15. PierreRochard deleted the branch on Aug 9, 2018
16. jasonbcox referenced this in commit 2720d3db04 on Dec 20, 2019
17. jonspock referenced this in commit ef730e104b on Oct 2, 2020
18. jonspock referenced this in commit 8e7f5f1f47 on Oct 5, 2020
19. jonspock referenced this in commit b27771b588 on Oct 10, 2020
20. UdjinM6 referenced this in commit f1fe92f86b on Jun 30, 2021
21. UdjinM6 referenced this in commit f1a20df0df on Jul 1, 2021
22. UdjinM6 referenced this in commit e3c64a7224 on Jul 2, 2021
23. UdjinM6 referenced this in commit 06d9afa13d on Jul 2, 2021
24. DrahtBot locked this on Sep 8, 2021

Contributors
PierreRochard jnewbery DrahtBot MarcoFalke fanquake kallewoof

Labels
Docs Wallet

Milestone
0.17.0