doc: Revert translated string change, clarify wallet log messages #13911
pull PierreRochard wants to merge 1 commits into bitcoin:master from PierreRochard:log-wallet-cleanup changing 1 files +3 −3-
PierreRochard commented at 3:04 PM on August 8, 2018: contributor
-
Trivial: Revert translated string change, clarify wallet log messages c4a884d555
- laanwj added this to the milestone 0.17.0 on Aug 8, 2018
- fanquake added the label Wallet on Aug 8, 2018
-
jnewbery commented at 3:47 PM on August 8, 2018: member
LGTM. Tested ACK c4a884d555e75cf43c695517f3f8344be177e5eb
-
DrahtBot commented at 3:56 PM on August 8, 2018: member
<!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:
- #10973 (Refactor: separate wallet from node by ryanofsky)
- #10102 ([experimental] Multiprocess bitcoin by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
MarcoFalke commented at 4:47 PM on August 8, 2018: member
utACK c4a884d555e75cf43c695517f3f8344be177e5eb
Can confirm that the only changes to translation strings are unrelated to this pull:
diff --git a/src/qt/bitcoinstrings.cpp b/src/qt/bitcoinstrings.cpp index ab7e56a9da..de60b30dfe 100644 --- a/src/qt/bitcoinstrings.cpp +++ b/src/qt/bitcoinstrings.cpp @@ -40,6 +40,12 @@ QT_TRANSLATE_NOOP("bitcoin-core", "" "Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -" "fallbackfee."), QT_TRANSLATE_NOOP("bitcoin-core", "" +"Group outputs by address, selecting all or none, instead of selecting on a " +"per-output basis. Privacy is improved as an address is only used once " +"(unless someone sends to it after spending from it), but may result in " +"slightly higher fees as suboptimal coin selection may result due to the " +"added limitation (default: %u)"), +QT_TRANSLATE_NOOP("bitcoin-core", "" "Invalid amount for -maxtxfee=<amount>: '%s' (must be at least the minrelay " "fee of %s to prevent stuck transactions)"), QT_TRANSLATE_NOOP("bitcoin-core", "" @@ -168,7 +174,7 @@ QT_TRANSLATE_NOOP("bitcoin-core", "Signing transaction failed"), QT_TRANSLATE_NOOP("bitcoin-core", "Specified -walletdir \"%s\" does not exist"), QT_TRANSLATE_NOOP("bitcoin-core", "Specified -walletdir \"%s\" is a relative path"), QT_TRANSLATE_NOOP("bitcoin-core", "Specified -walletdir \"%s\" is not a directory"), -QT_TRANSLATE_NOOP("bitcoin-core", "Specified blocks directory \"%s\" does not exist.\n"), +QT_TRANSLATE_NOOP("bitcoin-core", "Specified blocks directory \"%s\" does not exist."), QT_TRANSLATE_NOOP("bitcoin-core", "Starting network threads..."), QT_TRANSLATE_NOOP("bitcoin-core", "The source code is available from %s."), QT_TRANSLATE_NOOP("bitcoin-core", "The transaction amount is too small to pay the fee"), - MarcoFalke renamed this:
Trivial: Revert translated string change, clarify wallet log messages
doc: Revert translated string change, clarify wallet log messages
on Aug 8, 2018 - MarcoFalke added the label Docs on Aug 8, 2018
-
fanquake commented at 12:34 AM on August 9, 2018: member
utACK c4a884d
-
kallewoof commented at 6:40 AM on August 9, 2018: member
utACK c4a884d555e75cf43c695517f3f8344be177e5eb
- MarcoFalke merged this on Aug 9, 2018
- MarcoFalke closed this on Aug 9, 2018
- MarcoFalke referenced this in commit 3e3a50aeb8 on Aug 9, 2018
- PierreRochard deleted the branch on Aug 9, 2018
- jasonbcox referenced this in commit 2720d3db04 on Dec 20, 2019
- jonspock referenced this in commit ef730e104b on Oct 2, 2020
- jonspock referenced this in commit 8e7f5f1f47 on Oct 5, 2020
- jonspock referenced this in commit b27771b588 on Oct 10, 2020
- UdjinM6 referenced this in commit f1fe92f86b on Jun 30, 2021
- UdjinM6 referenced this in commit f1a20df0df on Jul 1, 2021
- UdjinM6 referenced this in commit e3c64a7224 on Jul 2, 2021
- UdjinM6 referenced this in commit 06d9afa13d on Jul 2, 2021
- DrahtBot locked this on Sep 8, 2021
Milestone
0.17.0