qa: Remove redundant checkmempool/checkblockindex extra_args #13913

1. 
   MarcoFalke commented at 6:39 pm on August 8, 2018: member

   They are already enabled by default for regtest:

   https://github.com/bitcoin/bitcoin/blob/df9f71274645a917e2578c52a1c59745bce8112d/src/init.cpp#L1002-L1007

   Closes #13912. CC #12138

2. qa: Remove redundant checkmempool/checkblockindex extra_args fa31ca0c22
3. MarcoFalke added the label Tests on Aug 8, 2018
4. 
   Empact commented at 11:27 pm on August 8, 2018: member

   Concept ACK. Could be interesting to disable these settings and see which tests require them.
5. 
   domob1812 commented at 9:56 am on August 9, 2018: contributor

   utACK fa31ca0c22b35beaceaf131b8f598280abdfd58d. @Empact: Why should any tests “require” these settings at all? They just make sure the tests enforce more things, no?
6. 
   Empact commented at 7:37 am on August 11, 2018: member

   utACK fa31ca0 @domob1812 I’m not that familiar with the checks, e.g. wrt to whether they have any side-effects, so I was curious to explore the counterfactual - if the checks are explicitly active now, and removing the explicit activation leaves them active by default, what happens if the default changes? Ran the affected tests with regtest fDefaultConsistencyChecks = false, and each passed, so seems good to me.
7. MarcoFalke merged this on Aug 11, 2018
8. MarcoFalke closed this on Aug 11, 2018

   ---

9. MarcoFalke referenced this in commit a08533c1a0 on Aug 11, 2018
10. MarcoFalke deleted the branch on Aug 11, 2018
11. PastaPastaPasta referenced this in commit 81bf95e464 on Jun 27, 2021
12. PastaPastaPasta referenced this in commit 23417499e0 on Jun 28, 2021
13. PastaPastaPasta referenced this in commit 5edf4694d4 on Jun 29, 2021
14. PastaPastaPasta referenced this in commit d42488ea69 on Jun 29, 2021
15. PastaPastaPasta referenced this in commit fa5755785b on Jun 29, 2021
16. PastaPastaPasta referenced this in commit f33c2c8101 on Jun 29, 2021
17. PastaPastaPasta referenced this in commit b04090df10 on Jun 29, 2021
18. MarcoFalke locked this on Sep 8, 2021

Contributors
MarcoFalke Empact domob1812

Labels
Tests