refactor: Make globals easier to identify by prefixing them g_. Avoid declaring variable and type in the same statement. #13919

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:globals-cleanup changing 8 files +19 −15

practicalswift commented at 10:28 PM on August 8, 2018: contributor
- Make globals easier to identify by prefixing them g_ (see developer notes).
- Make globals easier to identify by avoiding declaring variable and type in the same merged statement. (Some of the cases are not globals but included them for completeness.)
Make globals easier to identify by prefixing them g_. Avoid declaring variable and type in the same statement. 6de1edb5da
practicalswift force-pushed on Aug 8, 2018
promag commented at 11:14 PM on August 8, 2018: member

Make globals easier to identify by avoiding declaring variable and type in the same merged statement

Leave it for another PR? Kind of unrelated to the 1st point.

Regarding the 1st point I'm -0, most only exist for running code on static deallocation, so I kind of consider these exceptions to the rule.
practicalswift closed this on Aug 8, 2018
practicalswift commented at 11:26 PM on August 8, 2018: contributor

@promag You have a point - closing this PR. Regarding the other part, are you -1, +0 or +1 that change? :-)
promag commented at 11:46 PM on August 8, 2018: member

Also -0, maybe change the enums to enum class first?

I think these changes should have a strong rationale otherwise not worth it.
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors