Make format string linter understand basic template parameter syntax.
Fixes issue described in #13705 (comment).
Thanks to @ken2812221 for reporting!
lint: Make format string linter understand basic template parameter syntax #13939
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:teach-format-string-linter-about-templates changing 1 files +37 −1-
practicalswift commented at 3:35 PM on August 10, 2018: contributor
-
Make format string linter understand basic template parameter syntax 4441ad677a
-
laanwj commented at 3:52 PM on August 10, 2018: member
utACK 4441ad677a4cdc70ecac63e03edb4e236e36801e thanks for addressing this quickly ! need to be tested on @ken2812221's code
- laanwj added the label Tests on Aug 10, 2018
-
practicalswift commented at 10:11 AM on August 13, 2018: contributor
The first
doctesttestcase added is the issue @ken2812221 encountered. -
ken2812221 commented at 10:42 AM on August 13, 2018: contributor
Tested ACK 4441ad6. But
strprintf("%d %d", b<2, c);would fail, it would success if I add space either side of<. Maybe it's a good linter to telling people to format code. - ken2812221 referenced this in commit ef86f2631e on Aug 13, 2018
- MarcoFalke merged this on Aug 13, 2018
- MarcoFalke closed this on Aug 13, 2018
- practicalswift deleted the branch on Apr 10, 2021
- PastaPastaPasta referenced this in commit c62243ccf5 on Jun 27, 2021
- PastaPastaPasta referenced this in commit 4165dbc12a on Jun 28, 2021
- PastaPastaPasta referenced this in commit 1131377a0f on Jun 29, 2021
- PastaPastaPasta referenced this in commit 90e674cd15 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 38cd8acf93 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 674c68d39c on Jun 29, 2021
- PastaPastaPasta referenced this in commit 69c601c2c3 on Jun 29, 2021
- Fabcien referenced this in commit 5294ffff0f on Jan 11, 2022
- DrahtBot locked this on Aug 18, 2022
Contributors
Labels