tests: Port usage of deprecated optparse module to argparse module #13944

  69 | @@ -70,7 +70,7 @@ def custom_function():
  70 |  class ExampleTest(BitcoinTestFramework):
  71 |      # Each functional test is a subclass of the BitcoinTestFramework class.
  72 |  
  73 | -    # Override the set_test_params(), add_options(), setup_chain(), setup_network()
  74 | +    # Override the set_test_params(), add_arguments(), setup_chain(), setup_network()

MarcoFalke commented at 9:54 PM on August 11, 2018:

All of our arguments are options, so our name of this method can be left untouched.

 141 | +        parser.add_argument("--pdbonfailure", dest="pdbonfailure", default=False, action="store_true",
 142 | +                            help="Attach a python debugger if test fails")
 143 | +        parser.add_argument("--usecli", dest="usecli", default=False, action="store_true",
 144 | +                            help="use bitcoin-cli instead of RPC for all commands")
 145 |          self.add_options(parser)
 146 | -        (self.options, self.args) = parser.parse_args()

domob1812 commented at 9:34 AM on August 12, 2018:

I assume that no existing code relies on self.args (as otherwise you would see test failures)?

laanwj commented at 9:43 AM on August 12, 2018:

indeed, none of the code uses that as @MarcoFalke mentioned above, all the command-line arguments are options