Scripts and tools: fix gitian-build.py --verify option #14014

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:gitian-verify changing 1 files +5 −5

hebasto commented at 12:10 AM on August 21, 2018: member

The gitian-builder/bin/gverify script returns the exit code 1 if a signature verification ends with 'BAD SIGNATURE' or 'MISMATCH' by design. In these cases check_call() will raise CalledProcessError and gitian-build.py --verify will fail.

fix --verify option

The `gitian-builder/bin/gverify` script returns the exit code 1 if a signature verification ends with 'BAD SIGNATURE' or 'MISMATCH' by design.
In these cases `check_call()` will raise `CalledProcessError` and `gitian-build.py --verify` will fail.

e68cd2f5e0

fanquake added the label Scripts and tools on Aug 21, 2018
fanquake commented at 5:30 AM on October 20, 2018: member

@hebasto Can you combine this into #13998. Then I'll make sure I review that.
fanquake closed this on Oct 20, 2018
hebasto deleted the branch on Oct 20, 2018
hebasto commented at 10:59 AM on November 15, 2018: member

@fanquake This PR has been combined into #13998.
MarcoFalke referenced this in commit f49b8d4783 on May 20, 2019
sidhujag referenced this in commit 19c473999e on May 20, 2019
UdjinM6 referenced this in commit 84b3c0b1ee on Sep 1, 2021
UdjinM6 referenced this in commit 5baf92492b on Sep 2, 2021
UdjinM6 referenced this in commit 10c56c07b9 on Sep 2, 2021
UdjinM6 referenced this in commit 0f8ae5e6e6 on Sep 2, 2021
UdjinM6 referenced this in commit 678e2af0f3 on Sep 2, 2021
UdjinM6 referenced this in commit f512e704d5 on Sep 2, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

hebasto

fanquake

Labels

Scripts and tools

Linked (view graph)

#13998 Scripts and tools: gitian-build.py improvements and corrections