Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5, don't patch clang #14031

pull Empact wants to merge 1 commits into bitcoin:master from Empact:trivial-constructible-default changing 1 files +3 −3

Empact commented at 10:23 AM on August 23, 2018: member

std::is_trivially_constructible<T> is equivalent to std::is_trivially_default_constructible<T> std::has_trivial_default_constructor<T> is the GCC < 5 name for std::is_trivially_default_constructible<T>

https://en.cppreference.com/w/cpp/types/is_default_constructible https://www.gnu.org/software/gcc/gcc-5/changes.html

std::is_trivial was also used when compiling with clang, due to clang's use of __GNUC__. Test __clang__ to target the intended implementations. https://stackoverflow.com/a/28166605

All callers currently only pass one template argument to IS_TRIVIALLY_CONSTRUCTIBLE, with this change the build would fail if someone attempted passing more.
fanquake added the label Refactoring on Aug 23, 2018
Empact force-pushed on Aug 23, 2018

Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5

std::is_trivially_constructible<T> is equivalent to std::is_trivially_default_constructible<T>
std::has_trivial_default_constructor<T> is the GCC < 5 name for std::is_trivially_default_constructible<T>

std::is_trivial was also used when compiling with clang, due to clang's use of __GNUC__. Test __clang__
to target the intended implementations.

f1640d093f

Empact force-pushed on Aug 23, 2018
Empact renamed this:
~~Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5~~
Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5, don't patch clang
on Aug 23, 2018
laanwj commented at 9:39 AM on August 27, 2018: member

ACK f1640d093fa682c98b000e377916cc32b2267e23 Tested on gcc 4.8.4.
laanwj merged this on Aug 27, 2018
laanwj closed this on Aug 27, 2018
laanwj referenced this in commit cb98effc5c on Aug 27, 2018
PastaPastaPasta referenced this in commit ee444fb3f6 on Jun 27, 2021
PastaPastaPasta referenced this in commit 9833fee5ec on Jun 28, 2021
PastaPastaPasta referenced this in commit 6a406a8da5 on Jun 29, 2021
PastaPastaPasta referenced this in commit 15bf7e12ec on Jun 29, 2021
PastaPastaPasta referenced this in commit 99d2da692c on Jun 29, 2021
PastaPastaPasta referenced this in commit 934089b3d5 on Jun 29, 2021
PastaPastaPasta referenced this in commit 28dd824ada on Jun 29, 2021
Munkybooty referenced this in commit ef6b80ca78 on Jun 30, 2021
Munkybooty referenced this in commit c79103a9f0 on Jul 1, 2021
PastaPastaPasta referenced this in commit 70519e0495 on Jul 1, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Empact

laanwj

Labels

Refactoring