functional tests fail –with-sanitizers=undefined #14059

issue MarcoFalke openend this issue on August 24, 2018
  1. MarcoFalke commented at 11:03 pm on August 24, 2018: member

    Steps to reproduce on master and 0.17:

    0git checkout bitcoin/master && make distclean
    1./configure --with-sanitizers=undefined CC=clang CXX=clang++
    2make -j 16 check && ./test/functional/test_runner.py -j 16
    

    Runs into some divide by zero and other issues…

  2. fanquake added the label Tests on Aug 24, 2018
  3. practicalswift commented at 9:15 pm on September 20, 2018: contributor

    This is addressed in the following PRs:

    • #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...)
    • #14239: Avoid dividing by zero (undefined behaviour) in EstimateMedianVal (policy)/ConnectTip (validation)/CreateTransaction (wallet)
    • #13546: wallet: Avoid potential use of uninitialized value bnb_used in CWallet::CreateTransaction(...)
    • #14252: build: Run functional tests and benchmarks under the undefined behaviour sanitizer (UBSan)

    Please review :-)

  4. MarcoFalke referenced this in commit 1ba5583646 on Nov 5, 2018
  5. MarcoFalke closed this on Nov 17, 2018

  6. PastaPastaPasta referenced this in commit 1197a1f392 on Aug 16, 2021
  7. PastaPastaPasta referenced this in commit 857fae9277 on Aug 16, 2021
  8. PastaPastaPasta referenced this in commit 009f0059b9 on Aug 17, 2021
  9. PastaPastaPasta referenced this in commit b98e643250 on Aug 18, 2021
  10. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-18 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me