bench: Fix thread sanitizer issue in AssembleBlock benchmark #14083

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1808-benchAssembleBlockThread changing 1 files +8 −4

MarcoFalke commented at 3:37 PM on August 27, 2018: member

By destructing the blocks early in the loop, we could no longer read the hash of the first transaction (the only thing we are interested in).

So just keep all blocks fully in memory for the whole benchmark.
MarcoFalke added the label Needs backport on Aug 27, 2018
MarcoFalke added this to the milestone 0.17.0 on Aug 27, 2018
practicalswift commented at 3:43 PM on August 27, 2018: contributor

Concept ACK
MarcoFalke force-pushed on Aug 27, 2018
MarcoFalke force-pushed on Aug 27, 2018
MarcoFalke force-pushed on Aug 27, 2018
bench: Fix thread sanitizer issue in AssembleBlock benchmark fa7435d5d6
MarcoFalke force-pushed on Aug 27, 2018
MarcoFalke referenced this in commit 8fbcef44cd on Aug 27, 2018
MarcoFalke removed the label Needs backport on Aug 27, 2018
fanquake added the label Tests on Aug 27, 2018
DrahtBot commented at 10:59 AM on August 28, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #11652 (Add missing locks: validation.cpp + related by practicalswift)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke removed this from the milestone 0.17.0 on Aug 28, 2018
MarcoFalke closed this on Aug 29, 2018
MarcoFalke deleted the branch on Aug 29, 2018
practicalswift commented at 8:21 PM on August 29, 2018: contributor

@MarcoFalke Why the close? Fixed elsewhere?
MarcoFalke restored the branch on Aug 30, 2018
MarcoFalke deleted the branch on Aug 30, 2018
MarcoFalke commented at 7:22 PM on August 30, 2018: member

@practicalswift I can't reproduce this anymore, so maybe not worth spending time on this.
DrahtBot locked this on Sep 8, 2021

Contributors

Labels