tests: Fix accidental trunction from int to bool #14093

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:truncation-from-int-to-bool changing 1 files +1 −1

practicalswift commented at 2:57 PM on August 28, 2018: contributor

Fix accidental trunction from int to bool.

Context: #14086 (comment)
fanquake added the label Tests on Aug 28, 2018
in src/test/scheduler_tests.cpp:57 in 7957b7bde7 outdated
```
  53 | @@ -54,7 +54,7 @@ BOOST_AUTO_TEST_CASE(manythreads)
  54 |  
  55 |      boost::mutex counterMutex[10];
  56 |      int counter[10] = { 0 };
  57 | -    FastRandomContext rng(42);
  58 | +    FastRandomContext rng(true);
```
MarcoFalke commented at 3:24 PM on August 28, 2018:

please use named arguments for literal primitive types. {/* fDeterministic */ true}

practicalswift commented at 3:43 PM on August 28, 2018:

Good point! Fixed! :-)
tests: Fix accidental trunction from int to bool 1cc58978b7
practicalswift force-pushed on Aug 28, 2018
practicalswift commented at 7:33 PM on August 28, 2018: contributor

@MarcoFalke Thanks for reviewing. Feedback addressed. Please re-review :-)
MarcoFalke merged this on Aug 29, 2018
MarcoFalke closed this on Aug 29, 2018
MarcoFalke referenced this in commit 13887f41f2 on Aug 29, 2018
practicalswift deleted the branch on Apr 10, 2021
Munkybooty referenced this in commit a14593b6fa on Jun 14, 2021
PastaPastaPasta referenced this in commit 502f2a0c27 on Jun 27, 2021
PastaPastaPasta referenced this in commit b415c68084 on Jun 28, 2021
PastaPastaPasta referenced this in commit b1a59e9977 on Jun 29, 2021
PastaPastaPasta referenced this in commit 8d951c4222 on Jun 29, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

practicalswift

MarcoFalke

Labels

Tests

Linked (view graph)

#14086 appveyor: Use clcache to speed up build