validation: Log FormatStateMessage on ConnectBlock error in ConnectTip #14097

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1808-validationLogError changing 1 files +1 −1

MarcoFalke commented at 2:11 AM on August 29, 2018: member
This change additionally logs the validation state on error, which is not logged at all on current master.

Before:
```
ERROR: ConnectTip(): ConnectBlock ffffff.... failed
```
After:
```
ERROR: ConnectTip: ConnectBlock ffffff.... failed, bad-cb-amount (code 16)
```
validation: Log FormatStateMessage on ConnectBlock error in ConnectTip fa309dc305
MarcoFalke added the label Utils/log/libs on Aug 29, 2018
domob1812 commented at 6:03 AM on August 29, 2018: contributor

utACK fa309dc30579acebff33380abdfe728c1cf59f92. Thanks for this, I've been puzzled myself quite a couple of times what the actual issue is when debugging errors like that - very useful!
DrahtBot commented at 6:37 AM on August 29, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #9719 (Allow abort of ConnectBlock() when shutdown requested. by rebroad)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
practicalswift commented at 8:19 AM on August 29, 2018: contributor

utACK fa309dc30579acebff33380abdfe728c1cf59f92

Nice usability improvement by making the error message more meaningful!
laanwj merged this on Aug 29, 2018
laanwj closed this on Aug 29, 2018
laanwj referenced this in commit 4e9a6f87b7 on Aug 29, 2018
MarcoFalke deleted the branch on Aug 29, 2018
deadalnix referenced this in commit 382f0b2891 on Apr 22, 2020
ftrader referenced this in commit 5a274a8d54 on Aug 17, 2020
Munkybooty referenced this in commit 039645972f on Jun 30, 2021
Munkybooty referenced this in commit 2ca6e4f563 on Jun 30, 2021
Munkybooty referenced this in commit 271112da32 on Jul 2, 2021
Munkybooty referenced this in commit 506ddbfee2 on Jul 2, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels