qa: Use named args in validation acceptance tests #14101

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:Mf1808-qaNamedArgsAcceptance changing 5 files +158 −158

MarcoFalke commented at 4:56 PM on August 29, 2018: member

It is confusing to use a list of arguments such as False, False, 16, ... where it is unclear what each of them means.

Run some scripted diffs to put meaning to them.

scripted-diff: Pass node into p2p_segwit acceptance tests

-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/(test_witness_block|test_transaction_acceptance)\((self\.nodes\[.\])\.rpc/\1(\2/g' test/functional/p2p_segwit.py
-END VERIFY SCRIPT-

749ba35e7c

scripted-diff: Use named arguments in feature_block

-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e "s/sync_blocks\((.*?), (True|False), (1.?), /sync_blocks(\1, success=\2, reject_code=\3, reject_reason=/g" ./test/functional/feature_block.py
-END VERIFY SCRIPT-

b4d3309673

MarcoFalke added the label Tests on Aug 29, 2018
MarcoFalke force-pushed on Aug 29, 2018
qa: Use named args in some tests fa782a308d
MarcoFalke force-pushed on Aug 29, 2018
DrahtBot commented at 5:17 PM on August 29, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #14054 (p2p: Disable BIP 61 by default by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
promag commented at 12:15 AM on August 30, 2018: member

utACK fa782a3.

nit, could rename the following rpc arguments to node:

https://github.com/bitcoin/bitcoin/blob/4e9a6f87b7d25d56fca4166bd929003cf15c9b58/test/functional/p2p_segwit.py#L122

https://github.com/bitcoin/bitcoin/blob/4e9a6f87b7d25d56fca4166bd929003cf15c9b58/test/functional/p2p_segwit.py#L138
practicalswift commented at 11:34 AM on August 30, 2018: contributor

Concept ACK

Clearly improves code readability
laanwj commented at 11:08 PM on August 30, 2018: member

utACK fa782a308dbe7bc579c122f63c1c65666fc85e91
laanwj merged this on Aug 31, 2018
laanwj closed this on Aug 31, 2018
laanwj referenced this in commit 104aad1567 on Aug 31, 2018
MarcoFalke deleted the branch on Aug 31, 2018
MarcoFalke referenced this in commit 4bc1e8f098 on Oct 4, 2018
MarcoFalke referenced this in commit 4ab46a9039 on Oct 4, 2018
MarcoFalke referenced this in commit c897ae5566 on Oct 4, 2018
MarcoFalke referenced this in commit 96dc936862 on Oct 25, 2018
MarcoFalke referenced this in commit 73e538cf6a on Oct 25, 2018
MarcoFalke referenced this in commit 168efeaca6 on Oct 25, 2018
toxeus referenced this in commit 3b3707f45f on Nov 28, 2018
toxeus referenced this in commit 53952b5a96 on Nov 28, 2018
toxeus referenced this in commit c184d864b8 on Nov 28, 2018
Munkybooty referenced this in commit 8f2a6e54f5 on Jun 30, 2021
Munkybooty referenced this in commit 85c6553465 on Jul 2, 2021
Munkybooty referenced this in commit 025a33bb23 on Jul 2, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels