improve security #14116

pull fingera wants to merge 2 commits into bitcoin:master from fingera:4-improve-security changing 8 files +37 −11

fingera commented at 1:43 AM on August 31, 2018: contributor

some critical data does not clean in memory
improve security 922bbc80c7
fingera commented at 6:07 AM on August 31, 2018: contributor

Does this commit make sense? Should I to fix mingw link error?
add base58 security d0f951cb70
fingera force-pushed on Aug 31, 2018
gmaxwell commented at 12:20 AM on September 1, 2018: contributor

Without the ability to do mlockall it is not likely that efforts to zeroize secret data will be effective. We also have a special secret allocator that loads these things in special pages and zeroizes on free. If it isn't being used here we should change it to use it. But in the long run we should to move towards keeping secrets in a separate process which can be mlockall.
fingera commented at 2:12 AM on September 1, 2018: contributor

All *ssl libraries does cleanse. some data is in stack does't cleanup. maybe bitcoin code used in wallet app now. The most important thing is, can I do something?
separate wallet process is good idea, but is huge project. shoud i do it? happy weekend
promag commented at 11:54 PM on September 3, 2018: member

@fingera FYI #10102.
fingera commented at 1:15 AM on September 4, 2018: contributor

@promag thks, Is this commit should close? CHMAC_SHA512 is leak critical data in stack. 'special secret allocator' hook malloc and free is not useful. Page out is only threat?
fingera closed this on Sep 14, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

fingera

gmaxwell

promag