gui: Favor macOS show / hide action in dock menu #14133

pull promag wants to merge 1 commits into bitcoin:master from promag:2018-09-mac-showhide changing 1 files +3 −0

promag commented at 6:22 PM on September 2, 2018: member

Before:

<img width="188" alt="screen shot 2018-09-02 at 19 10 02" src="https://user-images.githubusercontent.com/3534524/44959393-5a44c400-aee5-11e8-90f4-9a30f67f7ee2.png">

After:

<img width="200" alt="screen shot 2018-09-02 at 19 19 01" src="https://user-images.githubusercontent.com/3534524/44959395-60d33b80-aee5-11e8-9773-1d04d3482115.png">

Note that macOS toggles between Hide and Show.
gui: Favor macOS show / hide action in dock menu ee3a494f37
fanquake added the label macOS on Sep 2, 2018
fanquake commented at 10:48 PM on September 2, 2018: member

Concept ACK. Having duplicate Show / Hide buttons on macOS has always been a bit confusing.

Happy for this to go in before #14123, as it simplifies testing that PR.
fanquake commented at 12:28 AM on September 3, 2018: member

tACK https://github.com/bitcoin/bitcoin/pull/14133/commits/ee3a494f37d6a459a5d935446ba08d69ea310b9b

master (https://github.com/bitcoin/bitcoin/commit/68f3c7eb080e461cfeac37f8db7034fe507241d0):

<img width="170" alt="master" src="https://user-images.githubusercontent.com/863730/44962443-17b9d080-af53-11e8-836d-67985450e674.png">

ee3a494f37d6a459a5d935446ba08d69ea310b9b:

<img width="171" alt="14133" src="https://user-images.githubusercontent.com/863730/44962447-230cfc00-af53-11e8-8a36-494bf6ab17a6.png">
fanquake commented at 10:41 AM on September 4, 2018: member

@Sjors or @jonasschnelli want to ack/nack?
Sjors commented at 11:37 AM on September 4, 2018: member

utACK ee3a494f37d6a459a5d935446ba08d69ea310b9b, less visual clutter is great
laanwj merged this on Sep 4, 2018
laanwj closed this on Sep 4, 2018
laanwj referenced this in commit bdfeb5dfa8 on Sep 4, 2018
promag deleted the branch on Sep 4, 2018
promag commented at 12:12 PM on September 4, 2018: member

Thanks
luke-jr referenced this in commit 1626725e8a on Dec 24, 2018
promag referenced this in commit 298dc15686 on Dec 30, 2018
laanwj referenced this in commit 5ff7b372cd on Jan 3, 2019
jasonbcox referenced this in commit 082ffb71c5 on Nov 22, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#15065 0.17: GUI Backports #14123 #14133 #14383 #14597