Remove ENABLE_WALLET from libbitcoin_server.a #14168

1. 
   jnewbery commented at 8:33 pm on September 7, 2018: member

   This removes the final instances of ENABLE_WALLET in libbitcoin_server and so completes #7965.
2. [build] Move dummy wallet into its own .cpp file.

   Removes the ifdef ENABLE_WALLET from init.cpp.

   3076556cd0
3. 
   jonasschnelli commented at 9:02 pm on September 7, 2018: contributor

   Strong Concept ACK
4. jonasschnelli added the label Wallet on Sep 7, 2018
5. jnewbery force-pushed on Sep 7, 2018
6. unknown approved
7. 
   DrahtBot commented at 11:17 pm on September 7, 2018: member

   • #10973 (Refactor: separate wallet from node by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. 
   laanwj commented at 3:45 am on September 8, 2018: member

   Yayyyy, good to see this finally happen utACK 9a2b3d2e9d5584adb19633485b5398accc3704b7
9. 
   donaloconnor commented at 3:59 pm on September 9, 2018: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/14168/commits/9a2b3d2e9d5584adb19633485b5398accc3704b7 - looks much cleaner :+1:
10. 
    ken2812221 commented at 4:02 pm on September 9, 2018: contributor

    utACK 9a2b3d2
11. [build] remove ENABLE_WALLET ifdef from httprpc.cpp 7d038dcb41
12. in src/wallet/init.cpp:23 in 9a2b3d2e9d outdated

    18@@ -19,6 +19,9 @@
    19 class WalletInit : public WalletInitInterface {
    20 public:
    21 
    22+    //! Is the wallet component enabled
    23+    bool IsWalletEnabled() const override {return true;}
    

    ---

    ---

    

    MarcoFalke commented at 5:19 pm on September 9, 2018:

    Should say IsWalletCompiled() or similar?

    ---

    

    promag commented at 5:35 pm on September 9, 2018:

    My suggestion HasWalletSupport().

    ---

    

    jnewbery commented at 6:27 pm on September 10, 2018:

    Changed to HasWalletSupport()
13. jnewbery force-pushed on Sep 10, 2018
14. 
    jnewbery commented at 6:27 pm on September 10, 2018: member

    Renamed function as suggested here: #14168 (review)
15. 
    Empact commented at 5:17 am on September 11, 2018: member

    utACK 7d038dc
16. 
    MarcoFalke commented at 1:46 pm on September 11, 2018: member

    utACK 7d038dcb41d93ea0b7401140998225adaab8c065
17. MarcoFalke referenced this in commit 4103cc3169 on Sep 11, 2018
18. MarcoFalke merged this on Sep 11, 2018
19. MarcoFalke closed this on Sep 11, 2018

    ---

20. jnewbery deleted the branch on Sep 11, 2018
21. deadalnix referenced this in commit 86358f3702 on Jan 27, 2020
22. Munkybooty referenced this in commit 120bb6235d on Jul 7, 2021
23. kittywhiskers referenced this in commit 799d9a69e1 on Aug 3, 2021
24. kittywhiskers referenced this in commit d7d2e18ac8 on Aug 3, 2021
25. kittywhiskers referenced this in commit ff7a1483cb on Aug 5, 2021
26. kittywhiskers referenced this in commit 1d11c77793 on Aug 5, 2021
27. kittywhiskers referenced this in commit 3d4de22480 on Aug 5, 2021
28. PastaPastaPasta referenced this in commit b54b0fb2a1 on Aug 6, 2021
29. kittywhiskers referenced this in commit 83bee9e21f on Aug 8, 2021
30. 5tefan referenced this in commit c04523c70f on Aug 10, 2021
31. kittywhiskers referenced this in commit 76e652aac7 on Aug 11, 2021
32. 5tefan referenced this in commit e08029a257 on Aug 12, 2021
33. DrahtBot locked this on Sep 8, 2021

Contributors
jnewbery jonasschnelli DrahtBot laanwj donaloconnor ken2812221 MarcoFalke promag Empact

Labels
Wallet