[wallet] Remove -usehd #14282

pull jnewbery wants to merge 2 commits into bitcoin:master from jnewbery:remove_usehd changing 5 files +8 −22
  1. jnewbery commented at 9:30 pm on September 20, 2018: member
    -usehd is no longer used (except to tell the user that they’ve set it incorrectly for the wallet that they’re loading). Remove it (in the same spirit as #14272)
  2. [wallet] Remove -usehd 25548b2958
  3. DrahtBot commented at 9:35 pm on September 20, 2018: member
  4. MarcoFalke added the label Wallet on Sep 20, 2018
  5. MarcoFalke commented at 9:39 pm on September 20, 2018: member

    This will throw even if it is set correctly, e.g. it will throw for a non-hd wallet to set -nousehd.

    utACK 25548b295861c19ad0c25319df727216f81f21a8

  6. jonasschnelli commented at 9:41 pm on September 20, 2018: contributor
    utACK 25548b295861c19ad0c25319df727216f81f21a8
  7. achow101 commented at 10:25 pm on September 20, 2018: member
    utACK 25548b295861c19ad0c25319df727216f81f21a8
  8. fanquake commented at 11:50 pm on September 20, 2018: member
    utACK 25548b2
  9. promag commented at 0:52 am on September 21, 2018: member

    This will force users to remove -usehd from configs. Add release note?

    BTW Tested ACK 25548b2.

  10. [docs] Add release notes for removing `-usehd` 7ac911afe7
  11. jnewbery commented at 9:33 pm on September 26, 2018: member

    Add release note?

    Done.

    I think the code change is ready for merge. It has 5 ACKs.

  12. promag commented at 9:36 pm on September 26, 2018: member

    Release note LGTM.

    ACK 7ac911a.

  13. MarcoFalke merged this on Sep 26, 2018
  14. MarcoFalke closed this on Sep 26, 2018

  15. MarcoFalke referenced this in commit ae1cc010b8 on Sep 26, 2018
  16. jnewbery deleted the branch on Sep 26, 2018
  17. deadalnix referenced this in commit 6930534e47 on Mar 17, 2020
  18. ftrader referenced this in commit 4e677069ad on May 19, 2020
  19. Munkybooty referenced this in commit 65a08b3535 on Jul 10, 2021
  20. Munkybooty referenced this in commit eb0fc1387b on Jul 10, 2021
  21. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-03 10:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me