tests: Use MakeUnique to construct objects owned by unique_ptrs #14287

1. 
   practicalswift commented at 9:05 am on September 21, 2018: contributor

   A subset of #14211 (“Use MakeUnique to construct objects owned by unique_ptrs”) as suggested by @MarcoFalke in #14211 (comment).

   Use MakeUnique to construct objects owned by unique_ptrs.

   Rationale:

   • MakeUnique ensures exception safety in complex expressions.
   • MakeUnique gives a more concise statement of the construction.
2. tests: Use MakeUnique to construct objects owned by unique_ptrs b6718e373e
3. MarcoFalke added the label Docs on Sep 21, 2018
4. MarcoFalke added the label Tests on Sep 21, 2018
5. 
   MarcoFalke commented at 12:09 pm on September 21, 2018: member

   utACK b6718e373ed425fa2440ddd8f1b05c76b782dc2b
6. 
   DrahtBot commented at 12:16 pm on September 21, 2018: member

   • #14224 (Document intentional and unintentional unsigned integer overflows (wraparounds) using annotations by practicalswift)
   • #14010 (tests: Setup chain parameters (globalChainParams) when performing fuzzing initialization by practicalswift)
   • #9381 (Remove CWalletTx merging logic from AddToWallet by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   donaloconnor commented at 5:21 pm on September 21, 2018: contributor

   utACK b6718e373ed425fa2440ddd8f1b05c76b782dc2b
8. MarcoFalke merged this on Sep 21, 2018
9. MarcoFalke closed this on Sep 21, 2018

   ---

10. MarcoFalke referenced this in commit 920c090f63 on Sep 21, 2018
11. practicalswift deleted the branch on Apr 10, 2021
12. Munkybooty referenced this in commit 25c9e682f6 on Jun 24, 2021
13. Munkybooty referenced this in commit 5f87520aa3 on Jun 24, 2021
14. Munkybooty referenced this in commit 6dcbddbf10 on Jun 28, 2021
15. Munkybooty referenced this in commit 36ba5267df on Jun 29, 2021
16. Munkybooty referenced this in commit afe42bd422 on Jun 29, 2021
17. Munkybooty referenced this in commit e48e6b5864 on Jun 29, 2021
18. gades referenced this in commit 2bfd797aac on May 1, 2022
19. malbit referenced this in commit 790788d3a3 on Aug 7, 2022
20. DrahtBot locked this on Aug 16, 2022

Contributors
practicalswift MarcoFalke DrahtBot donaloconnor

Labels
Docs Tests