Respond to getdata requests for transactions that are ancestors of newly-announced transactions. Currently, our software will request the parents of an orphan transaction from the peer who announced the orphan, but if our peer is running a recent Bitcoin Core version, the request would typically be dropped. So this should improve propagation for transaction chains, particularly for nodes that are just starting up.
(continued from #14220, which is now just a bugfix PR)
Depends on:
Prior to this commit, we'd respond with tx data for anything in mapRelay,
regardless of whether the requesting peer was one that we'd sent an INV to
for the transaction in question.
Close this privacy leak by maintaining a set of peers to which we've
relayed each transaction in mapRelay.
If we announce a transaction T to a peer, then we should also be willing to
provide T's parents to that peer (in case our peer is missing those parents).
This should improve propagation of transaction chains.
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
326@@ -295,6 +327,7 @@ def on_getdata(self, message): pass
327 def on_getheaders(self, message): pass
328 def on_headers(self, message): pass
329 def on_mempool(self, message): pass
330+ def on_notfound(self, message): pass
utACK https://github.com/bitcoin/bitcoin/pull/14318/commits/6b661802eb2baa206b3ba0f192be39c2b304cc00
For future reviewers: the INV for missing parents (which we currently expect may not be answered if relay interval on the remote node has lapsed) happens here: https://github.com/bitcoin/bitcoin/blob/d799efe21432ad55c41d5315f24c002bc8b3d119/src/net_processing.cpp#L2303-L2309
This PR is dependent on #14220 and probably shouldn’t be merged before that.
1168+ if vec is None:
1169+ self.vec = []
1170+ else:
1171+ self.vec = vec
1172+
1173+ def deserialize(self, f):
f? :-)
f is used consistently. Makes sense to follow that.
