doc: Fix PSBT howto and example parameters #14319

pull priscoan wants to merge 1 commits into bitcoin:master from priscoan:master changing 1 files +7 −7
  1. priscoan commented at 12:54 pm on September 25, 2018: contributor
  2. fanquake added the label Docs on Sep 25, 2018
  3. achow101 commented at 1:37 pm on September 25, 2018: member
    ACK f764fa661963df434847e217cadc3f07e2fba993
  4. MarcoFalke added the label Needs backport on Sep 25, 2018
  5. DrahtBot commented at 10:20 am on October 20, 2018: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14530 (Use RPCHelpMan to generate RPC doc strings by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. fanquake deleted a comment on Oct 29, 2018
  7. fanquake requested review from sipa on Oct 29, 2018
  8. in src/wallet/rpcwallet.cpp:3941 in f764fa6619 outdated
    3937@@ -3938,7 +3938,7 @@ UniValue walletcreatefundedpsbt(const JSONRPCRequest& request)
    3938 
    3939     if (request.fHelp || request.params.size() < 2 || request.params.size() > 5)
    3940         throw std::runtime_error(
    3941-                            "walletcreatefundedpsbt [{\"txid\":\"id\",\"vout\":n},...] [{\"address\":amount},{\"data\":\"hex\"},...] ( locktime ) ( replaceable ) ( options bip32derivs )\n"
    3942+                            "walletcreatefundedpsbt [{\"txid\":\"id\",\"vout\":n},...] [{\"address\":amount},{\"data\":\"hex\"},...] ( locktime ) ( options bip32derivs )\n"
    


    MarcoFalke commented at 5:37 pm on November 13, 2018:
    This is already fixed in master. Could remove this commit and avoid the merge conflict?

    MarcoFalke commented at 10:18 pm on December 5, 2018:
    Done with a force push (Hope you don’t mind)
  9. DrahtBot added the label Needs rebase on Nov 13, 2018
  10. MarcoFalke force-pushed on Dec 5, 2018
  11. MarcoFalke removed the label Needs backport on Dec 5, 2018
  12. doc: Fix PSBT howto and example parameters
    * Remove outdated reference to replaceable parameter
    * Fix address reference
    * Unify quotation and italicization of parameters
    * Fix PSBT reference
    78542a3f36
  13. MarcoFalke force-pushed on Dec 5, 2018
  14. MarcoFalke added this to the milestone 0.17.2 on Dec 5, 2018
  15. MarcoFalke added the label Needs backport on Dec 5, 2018
  16. DrahtBot removed the label Needs rebase on Dec 5, 2018
  17. fanquake commented at 6:52 am on December 13, 2018: member
    @achow101 Did you want to re-ack here
  18. achow101 commented at 7:07 am on December 13, 2018: member
    re-ACK 78542a3f36381fe96f60708834c8378042e3bab6
  19. fanquake commented at 12:16 pm on December 13, 2018: member
    utACK 78542a3
  20. laanwj merged this on Dec 13, 2018
  21. laanwj closed this on Dec 13, 2018

  22. laanwj referenced this in commit 24b3b788be on Dec 13, 2018
  23. fanquake referenced this in commit 7f6e79ee86 on Dec 13, 2018
  24. fanquake removed the label Needs backport on Dec 13, 2018
  25. fanquake commented at 1:23 pm on December 13, 2018: member
    Backported in #14945.
  26. fanquake referenced this in commit 0c65325c71 on Dec 13, 2018
  27. fanquake referenced this in commit 88c566a13f on Dec 28, 2018
  28. MarcoFalke referenced this in commit 16521ce086 on Dec 30, 2018
  29. deadalnix referenced this in commit f997599463 on Oct 5, 2020
  30. PastaPastaPasta referenced this in commit f8a5341857 on Jun 27, 2021
  31. PastaPastaPasta referenced this in commit a2fb99fb87 on Jun 28, 2021
  32. PastaPastaPasta referenced this in commit d4aaccd8cc on Jun 29, 2021
  33. linuxsh2 referenced this in commit 0ba35fbfe5 on Jul 29, 2021
  34. linuxsh2 referenced this in commit 26123fb60b on Jul 30, 2021
  35. linuxsh2 referenced this in commit 0720565814 on Aug 3, 2021
  36. MarcoFalke locked this on Sep 8, 2021


priscoan achow101 DrahtBot MarcoFalke fanquake


sipa

Labels
Docs

Milestone
0.17.2


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me