GUI: re-work current options dialog to a tabbed layout and use an UI-file #1433

1. 
   Diapolo commented at 10:21 am on June 9, 2012: none

   This needs a review and compilation test from a dev, but I want to ensure there is time to discuss it early!

   

   • re-work optionsdialog to a tabbed UI based on an ui-file / extend network options with a SOCKS version selection
   • changing “Unit to show amounts in:” now also updates the unit used in the transaction fee box
   • string updates
   • link Apply button and OK button when enabling or disabling them (how good is a disabled Apply button, if OK saves too ^^)
   • use LookupNumeric() from netbase to verify proxy address (via an EventFilter) - allows IPv6 and fixes #821
   • change proxy address field to QValidatedLineEdit and add visual feedback
   • add a status label used for displaying a message for invalid proxy addresses

   benefits:

   • much easier to expand, because it uses an UI-file, which can be edited via Qt Designer
   • IPv6 support for proxy address
   • SOCKS version selection

   The changes to optionsdialog.cpp/.h may look weird, but I designed it from scratch and only replace the current files, to keep the naming.

2. 
   laanwj commented at 11:19 am on June 9, 2012: member

   Haven’t had time to test it yet, but yeah this is better
3. 
   Diapolo commented at 12:10 pm on June 10, 2012: none

   Updated and added:

   • link Apply button and OK button when enabling or disabling them (how good is a disabled Apply button, if OK saves too ^^)
   • use LookupNumeric() from netbase to verify proxy address (via an EventFilter) - allows IPv6 and fixes #821
   • change proxy address field to QValidatedLineEdit and add visual feedback
   • add a status label used for displaying a message for invalid proxy addresses
4. 
   Diapolo commented at 9:16 pm on June 12, 2012: none

   Updated to reflect changes made in #1434 and use a well-formated commit message ;).
5. 
   laanwj commented at 6:32 am on June 13, 2012: member

   I’ve tested it, works great.

   The default dialog size is a bit small, I’d recommend making it a bit larger.

   Apart from that, ACK

6. 
   Diapolo commented at 1:00 pm on June 13, 2012: none

   I’m going to add a restart warning for enabling / disabling SOCKS proxy and will re-size the dialog a little. If this is in, it would be really nice to get this into 0.7, do you think that’s possible @laanwj?
7. 
   laanwj commented at 1:12 pm on June 13, 2012: member

   Yes, that’s possible. Gotta love UI-only changes.
8. 
   Diapolo commented at 1:53 pm on June 13, 2012: none

   Last update: make dialog a little bigger in size / add warning for enabling / disabling SOCKS proxy
9. re-work optionsdialog to a tabbed UI based on an ui-file

   - extend network options with a SOCKS version selection
   - changing "Unit to show amounts in:" now also updates the unit used in the transaction fee box
   - string updates
   - link Apply button and OK button when enabling or disabling them
   - use LookupNumeric() from netbase to verify proxy address (via an EventFilter)
   - change proxy address field to QValidatedLineEdit and add visual feedback
   - add a status label used for displaying a message for invalid proxy addresses
   - allow usage of IPv6 address as proxy address
   - added warning message when enabling / disabling SOCKS proxy

   c4443c2be1
10. in src/qt/optionsdialog.h: in 5c8cdde254 outdated

    69     OptionsModel *model;
    70     MonitoredDataMapper *mapper;
    71-    QPushButton *apply_button;
    72-
    73-    QList<OptionsPage*> pages;
    74+    bool fRestartWarningDisplayed_Lang;
    

    ---

    ---

    

    laanwj commented at 2:09 pm on June 13, 2012:

    Where is bool fRestartWarningDisplayed_Proxy?

    ---

    

    Diapolo commented at 2:25 pm on June 13, 2012:

    It was on a vacation … I missed the header-update, sorry :-/. Fixed!
11. 
    laanwj commented at 2:37 pm on June 13, 2012: member

    ACK

    We should find a more general way of doing the restart warnings later (for example, using a map of QWidget* instead of booleans, so that one function can be used), but that isn’t needed for this commit.

    BTW: we probably need a translations update after this?

12. laanwj referenced this in commit 44c89996c8 on Jun 13, 2012
13. laanwj merged this on Jun 13, 2012
14. laanwj closed this on Jun 13, 2012

    ---

15. 
    Diapolo commented at 3:53 pm on June 13, 2012: none

    We need for sure a translation update, yes :). I suggest you do a bitcoinstrings.cpp update and I will fetch current translations from Transifex, create a pull and tomorrow I’ll generate a new english master file.
16. coblee referenced this in commit 97609ebbd9 on Jul 17, 2012
17. lateminer referenced this in commit a34ae2e0a0 on Jan 22, 2019
18. lateminer referenced this in commit f5f6c3cd92 on May 6, 2020
19. DrahtBot locked this on Sep 8, 2021

Contributors
Diapolo laanwj