has anyone tested converttopsbt? #14355

1. 
   RHavar commented at 1:57 am on September 30, 2018: contributor

   I kind of suck at boolean algebra, but: https://github.com/bitcoin/bitcoin/blob/37612099ec7314b15a07d8bac55161ed4e8e7491/src/rpc/rawtransaction.cpp#L1672

   Unless I’m mistaken (which is highly likely) the whole thing can’t work (except the edge case where permitsigdata=true and you have no sig data)

2. fanquake added the label RPC/REST/ZMQ on Sep 30, 2018
3. 
   instagibbs commented at 1:59 am on September 30, 2018: member

   It’s indeed incorrect(the bool check at end is backwards), fixing and writing a basic test since there is none.
4. 
   practicalswift commented at 8:37 am on October 1, 2018: contributor

   Nice find @RHavar! Thanks for reporting!
5. laanwj closed this on Nov 12, 2018

   ---

6. laanwj referenced this in commit 47ed24cf8a on Nov 12, 2018
7. 
   instagibbs commented at 3:19 pm on November 27, 2018: member

   @RHavar what was the other issue you were having?
8. UdjinM6 referenced this in commit 59b51a86e7 on Jul 15, 2021
9. UdjinM6 referenced this in commit 7d66e6647b on Jul 15, 2021
10. MarcoFalke locked this on Sep 8, 2021
11. gades referenced this in commit dc23378b82 on Apr 30, 2022

Contributors
RHavar instagibbs practicalswift

Labels
RPC/REST/ZMQ