Fix OSX dmg issue (10.12 to 10.14) #14416

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2018/10/osx_dmg changing 1 files +1 −1
  1. jonasschnelli commented at 12:29 PM on October 6, 2018: contributor

    This seems to fix the macOS 10.12+ DMG issue in conjunction with Gitian on Bionic

  2. jonasschnelli added the label macOS on Oct 6, 2018
  3. fanquake added the label Build system on Oct 6, 2018
  4. MarcoFalke added the label Needs gitian build on Oct 8, 2018
  5. jonasschnelli force-pushed on Oct 8, 2018
  6. jonasschnelli force-pushed on Oct 8, 2018
  7. jonasschnelli force-pushed on Oct 8, 2018
  8. DrahtBot removed the label Needs gitian build on Oct 8, 2018
  9. jonasschnelli force-pushed on Oct 11, 2018
  10. jonasschnelli force-pushed on Oct 18, 2018
  11. jonasschnelli force-pushed on Oct 18, 2018
  12. laanwj added this to the "Blockers" column in a project
  13. jonasschnelli force-pushed on Oct 18, 2018
  14. jonasschnelli force-pushed on Oct 18, 2018
  15. jonasschnelli force-pushed on Oct 18, 2018
  16. jonasschnelli force-pushed on Oct 18, 2018
  17. jonasschnelli force-pushed on Oct 18, 2018
  18. jonasschnelli force-pushed on Oct 18, 2018
  19. jonasschnelli force-pushed on Oct 18, 2018
  20. jonasschnelli force-pushed on Oct 19, 2018
  21. jonasschnelli force-pushed on Oct 19, 2018
  22. jonasschnelli force-pushed on Oct 19, 2018
  23. jonasschnelli force-pushed on Oct 19, 2018
  24. jonasschnelli renamed this:
    [WIP] fix OSX dmg issue (10.12 to 10.14)
    Fix OSX dmg issue (10.12 to 10.14)
    on Oct 19, 2018
  25. jonasschnelli commented at 8:11 AM on October 19, 2018: contributor

    Figured out the issue. It seems to be the python binary string option for the WindowBounds.

    Gitian Build: https://bitcoin.jonasschnelli.ch/build/852

    Please test via you own Gitian Build (@fanquake, @Sjors, @ken2812221).

    Removed WIP tag.

  26. promag commented at 8:35 AM on October 19, 2018: member

    Tested ACK 898b7c3 on macOS 10.14 with @jonasschnelli build.

  27. MarcoFalke deleted a comment on Oct 20, 2018
  28. MarcoFalke added the label Needs gitian build on Oct 20, 2018
  29. MarcoFalke removed the label Needs gitian build on Oct 20, 2018
  30. MarcoFalke commented at 9:17 AM on October 20, 2018: member

    Could change the subject of the commit to something more meaningful?

  31. [macOS] Remove DS_Store WindowBounds bytes object 43719e0a34
  32. jonasschnelli force-pushed on Oct 20, 2018
  33. jonasschnelli commented at 1:13 PM on October 20, 2018: contributor

    @MarcoFalke: fixed.

  34. MarcoFalke added the label Needs gitian build on Oct 20, 2018
  35. DrahtBot commented at 2:06 PM on October 21, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 5c25409d6851182c5e351720cee36812c229b77a (master):

    Gitian builds for commit 73cb922ec63e6a751edfa89b42afd4fa00d2ea5f (master and this pull):

  36. DrahtBot removed the label Needs gitian build on Oct 21, 2018
  37. Sjors commented at 4:29 AM on October 23, 2018: member

    What "DMG issue in conjunction with Gitian on Bionic" are you referring to? Opening the first Gitian DMG above crashes, while the second works fine, so I guess that's the issue?

    Needs backport to 0.17?

    Still works as expected when I do make deploy on macOS (before and after look the same): <img width="511" alt="after" src="https://user-images.githubusercontent.com/10217/47335048-d8d70a00-d6bb-11e8-970f-27a7bbfc675b.png">

    Trying to build it using my own Gitian on Bionic is giving me headaches. I'm confused by the gitian-builder.py syntax. I tried the following:

    cd bitcoin
git remote add jonasschnelli https://github.com/jonasschnelli/bitcoin.git
git fetch jonasschnelli
cd ..
python3 gitian-build.py --detach-sign --no-commit --url https://github.com/jonasschnelli/bitcoin -o m -c -b sjors 2018/10/osx_dmg
2018/10/osx_dmg

    If you don't add the remote first you get (despite the --url argument):

    error: pathspec '2018/10/osx_dmg' did not match any file(s) known to git.

    But now I get: <img width="1340" alt="schermafbeelding 2018-10-23 om 12 21 51" src="https://user-images.githubusercontent.com/10217/47335561-4edc7080-d6be-11e8-8ab2-e465ad1b8f06.png">

  38. Sjors commented at 4:30 AM on October 23, 2018: member

    Fixes #14414

  39. ken2812221 commented at 5:57 AM on October 23, 2018: contributor

    @Sjors Try

    python3 gitian-build.py --detach-sign --no-commit --pull -o m -b sjors 14416
  40. Sjors commented at 7:33 AM on October 23, 2018: member

    @ken2812221 worked like a charm, thanks.

    My Gitian build produces a dmg that behaves on macOS 10.14

    920c0defbb516bbf34550f9551563124f986bdd375730985d0e2891f4016883d  bitcoin-0.17.99-osx-unsigned.dmg

    (@DrahtBot rebases on master so its hash is different)

    tACK 43719e0

  41. MarcoFalke commented at 8:15 PM on October 23, 2018: member

    Is this for backport?

  42. Sjors commented at 4:31 AM on October 24, 2018: member

    @MarcoFalke yes this should be backported to 0.17, as currently macOS users can't install that without a workaround. No need to backport to 0.16, because - I just tested - it doesn't have the issue (because Gitian Trusty builds?).

  43. fanquake added the label Needs backport on Oct 24, 2018
  44. MarcoFalke added this to the milestone 0.17.1 on Oct 24, 2018
  45. laanwj commented at 1:42 PM on October 25, 2018: member

    thank you for figuring it out! so it was a silly python unicode versus bytes issue :( utACK 43719e0a3411e6a08e04908332cb44adfa00c6a2

  46. laanwj merged this on Oct 25, 2018
  47. laanwj closed this on Oct 25, 2018
  48. laanwj referenced this in commit 754a00d55f on Oct 25, 2018
  49. laanwj referenced this in commit eb2cc84a31 on Oct 25, 2018
  50. jnewbery commented at 5:44 PM on October 25, 2018: member

    Thanks for fixing this @jonasschnelli! I see that the same commit (https://github.com/bitcoin/bitcoin/commit/18f05c765c800126b74a6d5b7f33cef7c9aae1b7) that changed the WindowsBounds value from a string to a bytes object also changed backgroundImageAlias to a bytes object. Does that also need to be changed back to a string for Python 3?

  51. fanquake removed this from the "Blockers" column in a project
  52. fanquake commented at 1:12 AM on October 26, 2018: member

    Backported in https://github.com/bitcoin/bitcoin/commit/eb2cc84a31fb923b2b25b979682904cb81edec7e.

  53. fanquake removed the label Needs backport on Oct 26, 2018
  54. UdjinM6 referenced this in commit afad6f1931 on May 24, 2021
  55. PastaPastaPasta referenced this in commit f7676c802d on May 25, 2021
  56. UdjinM6 referenced this in commit 3661f36bbd on Jun 3, 2021
  57. celbalrai referenced this in commit b301108b58 on Jul 15, 2021
  58. MarcoFalke locked this on Sep 8, 2021
Contributors
jonasschnellipromagMarcoFalkeDrahtBotSjorsken2812221laanwjjnewberyfanquake
Labels
macOSBuild system

Milestone
0.17.1

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me