Add checksum in gitian build scripts for ossl #14433

pull TheCharlatan wants to merge 1 commits into bitcoin:master from TheCharlatan:osslChecksum changing 2 files +5 −1

TheCharlatan commented at 9:28 PM on October 8, 2018: member

This adds a checksum in the gitian build script to make sure that ossl tool and theuni's patch matches what is expected. Also changes the url to use https.
fanquake added the label Scripts and tools on Oct 8, 2018
practicalswift commented at 4:35 AM on October 9, 2018: contributor

Concept ACK

Good catch!

in contrib/gitian-build.py:57 in 06bd2b0e7f outdated

  50 | @@ -51,8 +51,10 @@ def build():
  51 |      os.chdir('gitian-builder')
  52 |      os.makedirs('inputs', exist_ok=True)
  53 |  
  54 | -    subprocess.check_call(['wget', '-N', '-P', 'inputs', 'http://downloads.sourceforge.net/project/osslsigncode/osslsigncode/osslsigncode-1.7.1.tar.gz'])
  55 | +    subprocess.check_call(['wget', '-N', '-P', 'inputs', 'https://downloads.sourceforge.net/project/osslsigncode/osslsigncode/osslsigncode-1.7.1.tar.gz'])
  56 |      subprocess.check_call(['wget', '-N', '-P', 'inputs', 'https://bitcoincore.org/cfields/osslsigncode-Backports-to-1.7.1.patch'])
  57 | +    subprocess.check_output(["echo 'a8c4e9cafba922f89de0df1f2152e7be286aba73f78505169bc351a7938dd911 inputs/osslsigncode-Backports-to-1.7.1.patch' | sha256sum -c"], shell=True)
  58 | +    subprocess.check_output(["echo 'f9a8cdb38b9c309326764ebc937cba1523a3a751a7ab05df3ecc99d18ae466c9 inputs/osslsigncode-1.7.1.tar.gz' | sha256sum -c"], shell=True)

ken2812221 commented at 10:40 AM on October 9, 2018:

check_call?

TheCharlatan commented at 11:03 AM on October 9, 2018:

I think it does not terminate if you use check_call instead.

laanwj commented at 4:06 PM on January 9, 2019:

I'm not sure I understand why check_call wouldn't work here (or would hang). This is ignoring the result so the check_output call does the same as check_call except for swallowing stdout. In the case of check_call the output would go to the caller process' stdout.

TheCharlatan commented at 5:07 PM on January 9, 2019:

You are right, I force-pushed a change to check_call .

MarcoFalke commented at 7:39 PM on November 26, 2018: member

Could do the same for the manual instructions: https://github.com/bitcoin/bitcoin/pull/14799/files#r236341949
TheCharlatan force-pushed on Jan 9, 2019
MarcoFalke commented at 10:30 PM on January 9, 2019: member

Should do the same here: https://github.com/bitcoin/bitcoin/blame/5da08e0ac51682376767d823e76d2a92c61a5d97/doc/release-process.md#L90
TheCharlatan force-pushed on Jan 9, 2019
TheCharlatan commented at 10:43 PM on January 9, 2019: member

Force-pushed to update release doc as well.
DrahtBot added the label Needs rebase on Jan 9, 2019

Add checksum in gitian build scripts for ossl

This adds a checksum in the gitian build script to make sure that
ossl tool and theuni's patch matches what is expected. Also changes
the url to use https and adds the same instructions to the release docs.

03b8596dd6

TheCharlatan force-pushed on Jan 9, 2019
DrahtBot removed the label Needs rebase on Jan 9, 2019
laanwj commented at 3:54 PM on January 15, 2019: member

utACK 03b8596dd665d2f70c917794295911adb8680bcc
laanwj merged this on Jan 15, 2019
laanwj closed this on Jan 15, 2019
laanwj referenced this in commit eb2aecfb80 on Jan 15, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels