Implements proposal in #12948.
Progress:
- method implementation;
- functional test.
RPC method 'encodescript' #14470
pull rodentrabies wants to merge 1 commits into bitcoin:master from rodentrabies:encodescript-rpc changing 1 files +25 −0-
rodentrabies commented at 10:25 PM on October 12, 2018: contributor
-
rpc: implement 'encodescript' RPC method 1285a65a9e
- meshcollider added the label RPC/REST/ZMQ on Oct 12, 2018
-
meshcollider commented at 10:59 PM on October 12, 2018: contributor
Concept ACK
-
sipa commented at 3:19 AM on October 13, 2018: member
I don't think it's very useful to open a PR before you have an implementation.
If you have design questions that need to be solved first, you can open an issue, or comment on the existing one.
-
fanquake commented at 6:04 AM on October 13, 2018: member
I agree with @sipa. Pull requests are meant for code that's ready for review, they are not meant to be placeholders/a way to indicate you are working on something.
If you want to discuss technical approach/design, please do so in #12948. Then, once you have some code ready for review, please open a PR.
- fanquake closed this on Oct 13, 2018
-
rodentrabies commented at 8:33 AM on October 13, 2018: contributor
- rodentrabies renamed this:
[WIP] RPC method 'encodescript'
RPC method 'encodescript'
on Oct 13, 2018 -
rodentrabies commented at 7:32 PM on October 13, 2018: contributor
~Can this be reopened for review now? Tests are still missing but a straightforward implementation is ready.~ Edit: nevermind, I amended to the base branch commit and broke the tracking, so I'll just reopen myself.
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels