changed request payment button text and tab description #14484

pull HatboyWonder wants to merge 2 commits into bitcoin:master from HatboyWonder:master changing 2 files +2 −2

HatboyWonder commented at 9:49 AM on October 15, 2018: none

Small change by altering the text values for the request payment button and it's tab description to the ones suggested in #14482.

Closes #14482
changed request payment button text and tab description 59a9bd6d58
fanquake added the label GUI on Oct 15, 2018
jonasschnelli commented at 10:37 AM on October 15, 2018: contributor

utACK 59a9bd6d5895f0a2d96b505b73ed0ef1060c919c. Though we should probably discuss how we could remove the address book and eventually increase the usability of per-transaction comments and labels.
meshcollider commented at 10:53 AM on October 15, 2018: contributor

utACK https://github.com/bitcoin/bitcoin/pull/14484/commits/59a9bd6d5895f0a2d96b505b73ed0ef1060c919c @jonasschnelli agreed, this is a good first step for usability though
HatboyWonder commented at 12:07 PM on October 15, 2018: none

I can surely help with improving per-transaction comments and labels if you point me in the right direction.
in src/qt/forms/receivecoinsdialog.ui:111 in 59a9bd6d58 outdated
```
 107 | @@ -108,7 +108,7 @@
 108 |               </size>
 109 |              </property>
 110 |              <property name="text">
 111 | -             <string>&amp;Request payment</string>
 112 | +             <string>&amp;Receive payment</string>
```
luke-jr commented at 12:10 PM on October 15, 2018:

This doesn't seem literally correct. Receiving only happens when the sender sends. :/

HatboyWonder commented at 12:16 PM on October 15, 2018:

Should this text even change than. As far as I understand it's function it makes sense.

flack commented at 12:16 PM on October 15, 2018:

maybe call it something like "Create new receiving address" instead? (I guess "request payment" was also not literally correct, since it doesn't send a payment request anywhere AFAICT)

HatboyWonder commented at 12:33 PM on October 15, 2018:

Will do.

in src/qt/addressbookpage.cpp:110 in 59a9bd6d58 outdated

 106 | @@ -107,7 +107,7 @@ AddressBookPage::AddressBookPage(const PlatformStyle *platformStyle, Mode _mode,
 107 |          ui->newAddress->setVisible(true);
 108 |          break;
 109 |      case ReceivingTab:
 110 | -        ui->labelExplanation->setText(tr("These are your Bitcoin addresses for receiving payments. It is recommended to use a new receiving address for each transaction."));
 111 | +        ui->labelExplanation->setText(tr("These are your Bitcoin addresses for receiving payments. Use the request payment button in the receive tab to create new addresses."));

luke-jr commented at 12:10 PM on October 15, 2018:

If the button is getting renamed, it doesn't make sense to refer to the old name here.

HatboyWonder commented at 12:14 PM on October 15, 2018:

Agreed

luke-jr changes_requested
changed text from github comments c46a603d7a

in src/qt/addressbookpage.cpp:110 in c46a603d7a

 106 | @@ -107,7 +107,7 @@ AddressBookPage::AddressBookPage(const PlatformStyle *platformStyle, Mode _mode,
 107 |          ui->newAddress->setVisible(true);
 108 |          break;
 109 |      case ReceivingTab:
 110 | -        ui->labelExplanation->setText(tr("These are your Bitcoin addresses for receiving payments. Use the request payment button in the receive tab to create new addresses."));
 111 | +        ui->labelExplanation->setText(tr("These are your Bitcoin addresses for receiving payments. Use the 'Create new receiving address' button in the receive tab to create new addresses."));

luke-jr commented at 12:46 PM on October 15, 2018:

Nit: Prefer to have the button label here as a %1 token, so translations don't need to change when/if we rename the button again. (OTOH, the button itself needs &, so maybe not worth the trouble...)

in src/qt/forms/receivecoinsdialog.ui:111 in c46a603d7a

 107 | @@ -108,7 +108,7 @@
 108 |               </size>
 109 |              </property>
 110 |              <property name="text">
 111 | -             <string>&amp;Receive payment</string>
 112 | +             <string>&amp;Create new receiving address</string>

luke-jr commented at 12:47 PM on October 15, 2018:

Please keep r as the accelerator key.

promag commented at 12:59 PM on October 15, 2018: member

I think we shouldn't rush as this doesn't look consistent:

<img width="876" alt="screenshot 2018-10-15 at 13 54 23" src="https://user-images.githubusercontent.com/3534524/46952283-511d4a00-d082-11e8-81bb-c7e55c3b947c.png">

I agree with @jonasschnelli, first discuss, mock etc, and them implement?
HatboyWonder commented at 5:34 AM on October 16, 2018: none

I think we shouldn't rush as this doesn't look consistent:

<img alt="screenshot 2018-10-15 at 13 54 23" width="876" src="https://user-images.githubusercontent.com/3534524/46952283-511d4a00-d082-11e8-81bb-c7e55c3b947c.png">

I agree with @jonasschnelli, first discuss, mock etc, and them implement?

Ok so what is the scope of these changes. Should this be done in the course of this issue?
laanwj commented at 5:30 PM on January 16, 2019: member

This seems to have bled out a bit.
jonasschnelli commented at 8:00 AM on April 16, 2019: contributor

I think this is a general improvement. We can do further extensions/cleanup later. Lets merge this. utACK c46a603d7a149efa1e7af596e5437156d26742ac @HatboyWonder: can you squash the second commits since its basically overwriting your first commit.
fanquake commented at 1:14 PM on April 16, 2019: member

@jonasschnelli squashed/rebased in #15829.
fanquake closed this on Apr 16, 2019
nkostoulas referenced this in commit 0bde143fe5 on Apr 17, 2019
laanwj referenced this in commit 84adc79e10 on Apr 18, 2019
Munkybooty referenced this in commit aa07ae8219 on Sep 30, 2021
Munkybooty referenced this in commit 16e7bba8a8 on Oct 7, 2021
Munkybooty referenced this in commit 6d03cc8b9c on Oct 7, 2021
Munkybooty referenced this in commit 301006f068 on Oct 12, 2021
Munkybooty referenced this in commit 01177c37d7 on Oct 16, 2021
Munkybooty referenced this in commit 24a34997ca on Oct 20, 2021
Munkybooty referenced this in commit b0bb9b564c on Oct 21, 2021
Munkybooty referenced this in commit bff5d41165 on Oct 23, 2021
PastaPastaPasta referenced this in commit ed02615ccc on Oct 24, 2021
PastaPastaPasta referenced this in commit 7fa4ef1199 on Oct 25, 2021
pravblockc referenced this in commit 64f0a377b0 on Nov 18, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#14482 Better name for "Request Payment" button #15829 qt: update request payment button text and tab description